This repository has been archived by the owner on May 26, 2023. It is now read-only.
Expose control over gRPC max message length #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feedmeapples
changed the title
feedmeapples
force-pushed
the
control-grpc-message
branch
from
57be401
to
d1724fc
Compare
swyxio
reviewed
May 11, 2021
Comment on lines
14
to
16
| const grpcMaxMsgLength = | ||
| Number(process.env.TEMPORAL_GRPC_MAX_MESSAGE_LENGTH) || 4 * 1024 * 1024; | ||
|
|
There was a problem hiding this comment.
maybe want to move this lower down? this variable isnt used anywhere else.
feedmeapples
force-pushed
the
control-grpc-message
branch
from
d1724fc
to
b910369
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed:
Adds env flag to change the gRPC max message length limit
Why?
Gives users an option to display gRPC responses bigger than 4mb (default grpc message receive length limit).
Useful with APIs
ListOpenWorkflowExecutions,ListClosedWorkflowExecutionsandGetWorkflowExecutionHistoryChecklist
Closes issue:
How was this tested:
largepayloadsfixture from samples-go8 RESOURCE_EXHAUSTED: Received message larger than max (5243864 vs. 4194304)Updated README