Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

Make history events expandable on summary page #321

Merged
merged 1 commit into from
May 7, 2021

Conversation

feedmeapples
Copy link
Contributor

@feedmeapples feedmeapples commented May 5, 2021

What was changed:

Clicking on summary events expands them and shows details.
image

This is done by changing the eventId query parameter type from int to string, because grpc lib converts proto int64 fiields into strings, such as below becomes a string

message HistoryEvent {
    int64 event_id = 1;

Why?

Makes the summary events expand on clicking

Checklist

  1. Closes issue:

  2. How was this tested:

  • Open any workflow -> grid -> Summary
  • Click on any event
  • expected: Event expands and shows details
  1. Any docs updates needed?

No

@feedmeapples feedmeapples requested a review from swyxio May 5, 2021 19:09
@feedmeapples feedmeapples enabled auto-merge (squash) May 5, 2021 20:23
@feedmeapples feedmeapples merged commit b74266f into master May 7, 2021
@feedmeapples feedmeapples deleted the expand-summary branch May 7, 2021 16:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants