This repository has been archived by the owner on May 26, 2023. It is now read-only.
Show pending activitties as History events #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feedmeapples
force-pushed
the
pending-events
branch
from
d84f445
to
d7c4f85
Compare
feedmeapples
commented
May 4, 2021
client/routes/workflow/helpers/get-events-from-pending-activity.js
Outdated
Show resolved
Hide resolved
feedmeapples
commented
May 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed:
Pending Activities are now shown on History page as ActivityTaskStarted event
Why?
Makes it easier for users to see what's the state of workflow is, when activity tasks are being executed. The issue was coming because ActivityTaskStarted event is not added to history until the task is completed.
The change takes pending activities and shows them as ActivityTaskStarted events in history
Checklist
Closes issue:
How was this tested: