This repository has been archived by the owner on May 26, 2023. It is now read-only.
Fix queries not evaluating in ALL view #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feedmeapples
force-pushed
the
query-in-all-view
branch
from
5d37cf1
to
e3d666d
Compare
swyxio
approved these changes
Mar 31, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed:
Moved out the handling of Query based workflows filtering into its own handler. Before it was mixed with fetching by state (open/closed..). Made sure it is always executed regardless of the
statevariableWhy?
Fixes 'advanced' queries not being evaluated in ALL view
Closes issue:
Fixes #286
How has this been tested?
New e2e test
Any docs updates needed?
No