Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Expose command line option for Day/Night UI theming for development server #643

Open
SpencerC opened this issue Aug 21, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@SpencerC
Copy link

Is your feature request related to a problem? Please describe.

Every time we restart the development server using start-dev, we have to click the moon/sun button in the UI to change the theme to dark mode. It would be great (and probably pretty easy) to expose this as a command line option.

Describe the solution you'd like

Perhaps something like:

temporal server start-dev --ui-theme=night

Additional context

@SpencerC SpencerC added the enhancement New feature or request label Aug 21, 2024
@cretz
Copy link
Member

cretz commented Aug 21, 2024

The UI at https://github.com/temporalio/ui has a special environment variable for this called VITE_DARK_MODE, so you can export VITE_DARK_MODE=1 to get dark mode. Note, this has to be set before the first page view, otherwise the value is cached upon first view. We will look into documenting this variable.

Does this solve your need?

@ggrebert
Copy link
Contributor

works with temporalio/ui but not the temporal cli.
Same issue for TEMPORAL_UI_PUBLIC_PATH which is more blocking for me (working on a temporal extension for Quarkus)

To reproduce the issue:

docker run -it --rm --env TEMPORAL_UI_PUBLIC_PATH=/q/temporal --env VITE_DARK_MODE=1 -p 8233:8233 --entrypoint /usr/local/bin/temporal temporaliotest/auto-setup server start-dev --ip 0.0.0.0

@ggrebert
Copy link
Contributor

a PR is open to solve my issue (#644), but I haven't find a way to fix this issue

@SpencerC
Copy link
Author

Confirmed this is still an issue just tried setting VITE_DARK_MODE=1, and it had no effect on the CLI.

@cretz
Copy link
Member

cretz commented Sep 4, 2024

We have confirmed that the UI used in here does not expose this setting unlike if the UI is used directly. We have opened temporalio/ui#2308 to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants