Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent 2x token approvals when requesting additional approval #111

Open
rozzaswap opened this issue Jul 22, 2024 · 0 comments
Open

Prevent 2x token approvals when requesting additional approval #111

rozzaswap opened this issue Jul 22, 2024 · 0 comments

Comments

@rozzaswap
Copy link
Contributor

rozzaswap commented Jul 22, 2024

Describe the bug
Initial token approval if the user has a partial quantity allowance with the token for the bridge currently takes 2 transactions, one for 0 and another for the desired amount. Related to #110

Fix:

The bridge should figure out how large the allowance should be and request a transaction for that amount. The user is free to modify that on the wallet.

@rozzaswap rozzaswap self-assigned this Jul 22, 2024
@pmjanus pmjanus assigned rozzaswap and unassigned rozzaswap Aug 19, 2024
@rozzaswap rozzaswap removed their assignment Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant