Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Since 5.5.5 window image:preview is too translucency #28463

Open
unera opened this issue Sep 26, 2024 · 20 comments
Open

Since 5.5.5 window image:preview is too translucency #28463

unera opened this issue Sep 26, 2024 · 20 comments

Comments

@unera
Copy link

unera commented Sep 26, 2024

Steps to reproduce

Debian/11
5.5.5 (static)

Expected behaviour

See above

Actual behaviour

For example I see an image in chat:

изображение

If I click, I see something soap:

изображение

Operating system

Debian/11

Version of Telegram Desktop

5.5.5

Installation source

Static binary from official website

Crash ID

No response

Logs

No response

@unera unera added the bug label Sep 26, 2024
@unera
Copy link
Author

unera commented Sep 26, 2024

Example 2 (chat):

изображение

Preview:

изображение

@unera
Copy link
Author

unera commented Sep 26, 2024

Addtitonal, 5.5.4 work fine :)

Chat:
изображение

Preview:

изображение

@unera
Copy link
Author

unera commented Sep 26, 2024

So at my system

So, I disabled autoupgrade system in my 5.5.4 version

@ilya-fedin
Copy link
Contributor

Can't reproduce any of three. Media viewer works just fine.

@unera
Copy link
Author

unera commented Sep 26, 2024

Can't reproduce any of three. Media viewer works just fine.

see screenshots

@ilya-fedin
Copy link
Contributor

see screenshots

And? I can't confirm it happens. Without a way to reproduce the issue couldn't be worked on.

@unera
Copy link
Author

unera commented Sep 26, 2024

see screenshots

And? I can't confirm it happens. Without a way to reproduce the issue couldn't be worked on.

  1. I have Debian/11 & Telegram
  2. I have some problems that are appeared since latest upgrades (5.5.5, 5.5.6 beta)
  3. Downgrade solves the problems
  4. All problems touche image:preview

So I think that You could look through code changes, that touche image:preview?

Also If You say, I could try any experiments, note library versions, logs, etc.

@ilya-fedin
Copy link
Contributor

So I think that You could look through code changes, that touche image:preview?

There were no code changes that touch it
v5.5.4...v5.5.5

@unera
Copy link
Author

unera commented Sep 26, 2024

So I think that You could look through code changes, that touche image:preview?

There were no code changes that touch it v5.5.4...v5.5.5

I can't understand C++, so it would be nice if You help me

Situation:

  • 5.5.4 works
  • 5.5.5 has problems
  • 5.5.6 has more problems than 5.5.5

What (as user) I could do?

@ilya-fedin
Copy link
Contributor

I recommend reproducing on a VM. You will likely find which steps to reproduce are lacking while doing that.

@ilya-fedin
Copy link
Contributor

ilya-fedin commented Sep 26, 2024

I will also honestly say no one tests tdesktop with Debian. Personally I use NixOS with Plasma 6 Wayland and have a VM with KDE neon user edition, @john-preston uses WSL. Previously he tested with Ubuntu 22.04 in a VM but not sure he does that now.

So it might be just that your distro/DE is incompatible with what tdesktop is tested for and it might be a good idea to switch to another one for stable work with tdesktop.

There are no resources to test more distros/DEs, sorry.

@kolayne
Copy link

kolayne commented Oct 1, 2024

Good evening.

@ilya-fedin, I am having a similar issue (except not yet in version 5.5.5) on my Arch Linux, with i3 version 4.23, picom version 11.2 (vgit-89c2c).

I've tried bisecting. The last good commit is 7abc921, then two commits follow for which the build is failing, and then 3f6d184 is the first bad commit.

Looking at the changes manually, I presume, the actual reason is the commit 4a84f9f, which updates the lib_ui submodule

@ilya-fedin
Copy link
Contributor

The initial reporter claims this problem is since 5.5.5 while this commit is way later than 5.5.5?

@ilya-fedin
Copy link
Contributor

ilya-fedin commented Oct 1, 2024

It feels to me that the problem in your compositors or drivers as I can't reproduce anything like that with any version on my Plasma system

@kolayne
Copy link

kolayne commented Oct 2, 2024

The initial reporter claims this problem is since 5.5.5 while this commit is way later than 5.5.5?

That's surprising for me as well. Like I said, version 5.5.5 works fine for me.

the problem in your compositors or drivers

Huh! In my laptop I have an nvidia video card with the 560.35.03 nvidia driver installed and NVidia Optimus enabled (that is, by default applications do not access the discrete video card).

I have first tried to uninstall the drivers (and reboot) and the issue persisted, then I tried to install the drivers again and run prime-run ./Telegram which would make it use the discrete video card and the issue was gone!

(examining prime-run on my system and running with different options, I found that the environment variable __GLX_VENDOR_LIBRARY_NAME=nvidia is the necessary and sufficient one)

I'm surprised. Does that tell you anything?

@ilya-fedin
Copy link
Contributor

It means the issue in the driver and nothing could be done about it...

@kolayne
Copy link

kolayne commented Oct 2, 2024

Two more observations:

  • The problem is introduced in desktop-app/lib_ui@1dec2a1. Telegram Desktop compiled with a version of lib_ui before that commit doesn't have this problem
  • Disabling the "Enable OpenGL rendering for media" in the "Advanced" settings fixes the regular Telegram Desktop version (@unera, I would recommend you to try the same)

@ilya-fedin
Copy link
Contributor

Had the window transparent background before? That window is supposed to have transparent background and the commit you refer fixes applying the transparency hint in OpenGL case (previously it had random success of being applied). If your driver can't handle transparency properly, nothing could be done about that.

@kolayne
Copy link

kolayne commented Oct 3, 2024

No, the media viewer background was not transparent.

If your driver can't handle transparency properly, nothing could be done about that.

Well, generally, both my driver and compositor support transparency, as I have other applications with transparent windows rendered correctly. But I am not sure whether they are using OpenGL

@ilya-fedin
Copy link
Contributor

Even if they use opengl, they likely use other toolkit and that's likely specific to how the driver and the toolkit interact

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants