Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watcher stores PipelineRun YAML without taskRunTemplate, podTemplate and env vars #730

Open
manuelwallrapp opened this issue Mar 14, 2024 · 9 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@manuelwallrapp
Copy link
Contributor

manuelwallrapp commented Mar 14, 2024

Expected Behavior

I expect that the PipelineRun YAML are saved completely as it appears in Openshift including the taskRunTemplate. But that is not the case.

kind: "PipelineRun"
spec:
......
taskRunTemplate:
podTemplate:
affinity:
nodeAffinity:
requiredDuringSchedulingIgnoredDuringExecution:
nodeSelectorTerms:
- matchExpressions:
- key: node-role.kubernetes.io/batch
operator: Exists
env:
- name: CI
value: 'true'

Actual Behavior

the complete taskRunTemplate under the PipelineRun spec is not stored, which makes an exact rerun of the stored YAML difficult. We need to store the taskRunTemplates with its env vars as well.

Steps to Reproduce the Problem

  1. Start a PipelineRun with a defined taskRunTemplate which contains a podTemplate including env vars.
  2. Compare the YAML in Openshift and the YAML in Tekton-Results. The whole taskRunTemplate with podTemplate is missing.

Additional Info

  • Kubernetes version:

    Output of kubectl version:

Client Version: 4.14.5
Kustomize Version: v5.0.1
Server Version: 4.14.14
Kubernetes Version: v1.27.10+28ed2d7


- Tekton Pipeline version:

**Output of `tkn version` or `kubectl get pods -n tekton-pipelines -l app=tekton-pipelines-controller -o=jsonpath='{.items[0].metadata.labels.version}'`**

Client version: 0.34.0
Chains version: v0.16.1
Pipeline version: v0.47.6
Triggers version: v0.24.2

@manuelwallrapp manuelwallrapp added the kind/bug Categorizes issue or PR as related to a bug. label Mar 14, 2024
@manuelwallrapp manuelwallrapp changed the title Pie PipelineRun YAML not saved completely Mar 14, 2024
@manuelwallrapp manuelwallrapp changed the title PipelineRun YAML not saved completely PipelineRun YAML saved without taskRunTemplate, podTemplate and env vars Mar 14, 2024
@manuelwallrapp manuelwallrapp changed the title PipelineRun YAML saved without taskRunTemplate, podTemplate and env vars Watcher stores PipelineRun YAML without taskRunTemplate, podTemplate and env vars Mar 14, 2024
@khrm
Copy link
Contributor

khrm commented Mar 14, 2024

You will find these fields in a different location where they exist in v1beta1.

We need to move to v1 from v1beta1. There's already an issue on that and TEP.

@khrm
Copy link
Contributor

khrm commented Mar 14, 2024

@avinal I assume you will work on v1beta1 to v1 conversion soon? These issues will keep coming up if we don't move to v1 soon.

@khrm khrm added this to the v0.10.0 milestone Mar 14, 2024
@manuelwallrapp
Copy link
Contributor Author

manuelwallrapp commented Mar 15, 2024

I see, we can not do anything on our side, since our PipelineRuns are using v1 and TektonResults doesn't support yet the full structure of v1 including taskRunTemplate.

@khrm
Copy link
Contributor

khrm commented Mar 15, 2024

@manuelwallrapp Yes, when we move to v1 in Results, it will be resolved.

@thomascube
Copy link

I assume #303 is the related issue, right?

@khrm
Copy link
Contributor

khrm commented May 10, 2024

Yes. This should be fixed in v0.11.0

@khrm khrm modified the milestones: v0.10.0, v0.11.0 May 10, 2024
@thomascube
Copy link

v0.11.0 is out but with different features. Do you have a new milestone ETA?

@khrm
Copy link
Contributor

khrm commented Jul 18, 2024

@thomascube It should be fixed in the next release. A PR for this is already merged.

@khrm
Copy link
Contributor

khrm commented Jul 18, 2024

/assign @khrm

@khrm khrm modified the milestones: v0.11.0, v0.12.0 Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

3 participants