Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve log messages and log configurations #543

Open
Tracked by #526
sayan-biswas opened this issue Jul 28, 2023 · 1 comment
Open
Tracked by #526

Improve log messages and log configurations #543

sayan-biswas opened this issue Jul 28, 2023 · 1 comment
Labels
kind/misc Categorizes issue or PR as a miscellaneuous one. lifecycle/stale

Comments

@sayan-biswas
Copy link
Contributor

sayan-biswas commented Jul 28, 2023

  1. Presently in tekton results, we do have zap logging configured in both API server and Watcher, but the configuration process in the knative based watcher is not uniform with configuration in the API server. Also the zap configuration in the API server doesn't take advantage of the atomic log level feature in zap and neither the ConfigMap is watched. As a result if we change the log level in the config it doesn't reflect in the API service immediately and it needs to be restarted to to use the updated log level.

  2. Most of the log messages are not organised (warning, error, log) and also the message itself is too generic with few parameter to correctly identify the source of the issue. Specially in the logs API related methods.

@sayan-biswas sayan-biswas added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Jul 28, 2023
@tekton-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/misc Categorizes issue or PR as a miscellaneuous one. lifecycle/stale
Projects
None yet
Development

No branches or pull requests

2 participants