Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up health checking provided the service name #414

Closed
3 tasks
avinal opened this issue Mar 23, 2023 · 3 comments · Fixed by #485
Closed
3 tasks

Set up health checking provided the service name #414

avinal opened this issue Mar 23, 2023 · 3 comments · Fixed by #485
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@avinal
Copy link
Member

avinal commented Mar 23, 2023

Feature request

The current health checking only checks for Results service.

results/cmd/api/main.go

Lines 150 to 153 in 2b03ffa

// Set up health checks.
hs := health.NewServer()
hs.SetServingStatus("tekton.results.v1alpha2.Results", healthpb.HealthCheckResponse_SERVING)
healthpb.RegisterHealthServer(s, hs)

Update the health service for the following. Refer: https://github.com/grpc/grpc/blob/master/doc/health-checking.md

  • Implement the Health Service
  • Add REST endpoint for the health service
  • Add Logs service to health checking
@avinal avinal added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 23, 2023
@avinal
Copy link
Member Author

avinal commented Mar 23, 2023

I can take on this issue.

@khrm
Copy link
Contributor

khrm commented Mar 23, 2023

/assign @avinal

@avinal
Copy link
Member Author

avinal commented May 23, 2023

/assign @sayan-biswas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants