Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README pointing to wrong lines in "Firmware Setup" #21

Open
bradyjhenry opened this issue Jul 30, 2021 · 1 comment
Open

README pointing to wrong lines in "Firmware Setup" #21

bradyjhenry opened this issue Jul 30, 2021 · 1 comment

Comments

@bradyjhenry
Copy link

bradyjhenry commented Jul 30, 2021

In step 7 of the 'Firmware Setup' section of the readme, the hyperlink for the sensor array points here:

fsr/fsr.ino

Lines 204 to 209 in 365fed5

for (size_t i = 0; i < num_sensors_; ++i) {
if (individual_states_[i] == SensorState::ON) {
turn_on = true;
break;
}
}

where it should be pointing here:

fsr/fsr.ino

Lines 428 to 433 in 365fed5

Sensor kSensors[] = {
Sensor(A0),
Sensor(A1),
Sensor(A2),
Sensor(A3),
};

not super crucial but could be confusing

@teejusb
Copy link
Owner

teejusb commented Jul 30, 2021

Ah thanks! I updated the ino and looks like I didn't update the README accordingly. Thanks! I'll update this in a little bit.

@alex-ong alex-ong mentioned this issue Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants