Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit b6f9f4e3eb051f66fd41ca00d91368e1bc7cb848 introduced backward incompatibility #295

Closed
behrica opened this issue Mar 8, 2022 · 1 comment

Comments

@behrica
Copy link
Contributor

behrica commented Mar 8, 2022

In dataset.clj before that commit,

the function new-col was re-exported twice, probably by mistake.


so the second one "won".

After the change, only the first one stayed, having a different arrity and probably doing something different as well.

So any code using tech.ml.dataset.new-column before b6f9f4e will stop compiling
when moving to b6f9f4e + 1.

 :at [clojure.lang.Compiler$InvokeExpr eval Compiler.java 3711]}
  {:type clojure.lang.ArityException
   :message Wrong number of args (2) passed to: tech.v3.dataset/new-column
   :at [clojure.lang.AFn throwArity AFn.java 429]}]

As this is in the main namespace it might affect some people.

@cnuernber
Copy link
Collaborator

Great catch thanks a lot for tracking this down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants