Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI and github actions #88

Closed
gedw99 opened this issue May 31, 2021 · 3 comments
Closed

CI and github actions #88

gedw99 opened this issue May 31, 2021 · 3 comments

Comments

@gedw99
Copy link

gedw99 commented May 31, 2021

SO i was thinking that CI is really needed, and have been using this approach which you might like to use.

Nice explicit make files:
https://github.com/jerson/openpgp-mobile/blob/flatbuffers/Makefile

Git hub actions just calls the same make files:
https://github.com/jerson/openpgp-mobile/tree/flatbuffers/.github/workflows

That gets you the ability to have the same make target run for many platforms ( desktop, mobile, wasm)

Then because you have many examples to CI, you can wrap the calls to the make file targets with a strategy pattern like here:
https://github.com/amplify-edge/main/blob/master/.github/workflows/ci.yml#L17

Please notice down the very bottom how the make file asked for is then called.

I like this pattern because the same make target is run on your laptop and in CI. Its less work to maintain and you know that whats happens locally is what happen in github ci. When you change your makefiles and you dont have to change your CI workflow files.

@tdewolff
Copy link
Owner

Sounds like an excellent idea! I don't have much time for the moment, but if you want to give it a start in a PR I'd appreciate it!

@gedw99
Copy link
Author

gedw99 commented Jun 15, 2021

@tdewolff would love to but also way out of time...

If i get a break will swing back to this..

@tdewolff tdewolff closed this as completed Apr 6, 2023
@tdewolff tdewolff mentioned this issue Apr 6, 2023
42 tasks
@tdewolff
Copy link
Owner

tdewolff commented Apr 6, 2023

Moved to roadmap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants