Add type definitions. #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
|
Hey 👋 I'll take a look at this tonight. |
|
Hey @yeldiRium sorry for the delay. Getting this merged in now!! Thank you so much for the help. I really appreciate it. |
|
Thanks a lot for accepting it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Hi 👋
I want to use this cool tool in a TypeScript project I am working on. Since the linter is written in JavaScript and has no type definitions, I thought I'd contribute some TypeScript types. They should cover the entire public-facing API.
Please tell me if I misunderstood some parameters or if you'd rather move the
index.d.tsfile to a different location.Checklist