Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add metrics on call event #1089

Open
wants to merge 2 commits into
base: develop_tchap
Choose a base branch
from
Open

add metrics on call event #1089

wants to merge 2 commits into from

Conversation

mcalinghee
Copy link
Contributor

@mcalinghee mcalinghee commented Aug 8, 2024 •
edited
Loading

Cas d'usage

  • Scenario 1 : appel de user A vers user B - user A doit envoyer un event CallStarted lors de l'emission d'un appel (au démarrage de l'appel)
  • Scenario 2 : appel de user A vers user B - user B doit envoyer un event CallStarted lors de la réception et acceptation d'un appel (au démarrage de l'appel)
  • Scenario 3 : appel de user A vers user B - user A doit envoyer un event CallEnded lors de la fin d'appel lorsque user A termine l'appel
  • Scenario 4 : appel de user A vers user B - user B doit envoyer un event CallEnded lors de la fin d'appel lorsque user A termine l'appel

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@mcalinghee mcalinghee linked an issue Aug 8, 2024 that may be closed by this pull request
Add metrics call #1088
Open
@gitguardian GitGuardian
Copy link

gitguardian bot commented Aug 12, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13361669 Triggered Generic High Entropy Secret 406b9af config.dev.json View secret
🛠 Guidelines to remediate hardcoded secrets

  1. Revoke and rotate the secret.

  2. If possible, rewrite git history with git commit --amend and git push --force.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@mcalinghee mcalinghee marked this pull request as ready for review August 13, 2024 07:42
NicolasBuquet
NicolasBuquet approved these changes Aug 13, 2024
View reviewed changes
Copy link

@NicolasBuquet NicolasBuquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mcalinghee
mcalinghee commented Aug 13, 2024
View reviewed changes
config.dev.json
@@ -107,6 +107,11 @@
"text": "Read the Privacy Policy"
}
],
"posthog": {
"project_api_key": "phc_eQOeaQiaIxdX9kaQmqYTD7RJLyFubYmGYKUI9czqqQD",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai mis la cle comme chez element-web ou android en attendant d'avoir une infra de dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasBuquet NicolasBuquet NicolasBuquet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add metrics call
2 participants
@mcalinghee @NicolasBuquet