-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
renaming take
#270
Comments
The committee decided today to not go through with the rename of |
Just adding my thoughts here as I write a library for ReScript. |
@jmagaram yeah the committee isn't great at making amendments and taking feedback once a proposal is past stage 2 unless "political force" is applied and that's expensive. From my perspective - the fact it's confusing and a (clear IMO) mistake isn't enough reason to do anything that will block this proposal since I need/want the 99% other stuff in it. |
Per discussion in this thread, some users infer/want that you can
take
multiple times from the iterator to get multiple chunks. But because exhausting thetake
subiterator closes the underlying iterator, you can't actually do that. That may be confusing if you're used to e.g. rust iterators.We should probably rename it. My preference is to use
limit
, which is what Java calls it.(And while we're at it we will probably want to rename
drop
toskip
, sincetake
is always paired withdrop
andlimit
withskip
.)Do read the discussion in the original thread. I wanted to open a separate issue so we could track it properly. cc @benjamingr
The text was updated successfully, but these errors were encountered: