Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] add an option to let taxpasta report relative abundance as fractions instead of only counts #142

Open
1 task done
Midnighter opened this issue Jan 2, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@Midnighter
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Problem description

See discussion on Slack reported by @AmaliT.

The following config causes errors:

motus_use_relative_abundance:true
motus_save_mgc_read_counts:true

Code sample

             CRITICAL   schema_context      column           check    merge.py:424
                      check_number failure_case index                             
                      0         Column  read_count  dtype('int64')                
                      None      float64  None  

Environment

taxprofiler pipeline

Anything else?

No response

@Midnighter Midnighter added the bug Something isn't working label Jan 2, 2024
@Midnighter Midnighter self-assigned this Jan 2, 2024
@Midnighter
Copy link
Contributor Author

After some more discussion on Slack, we decided that we should continue to only read input of integer counts, but add an option to taxpasta to report fractions.

@Midnighter Midnighter changed the title [BUG] mOTUs profile with fractions causes error [Feature] add an option to let taxpasta report relative abundance as fractions instead of only counts Apr 6, 2024
@Midnighter Midnighter added enhancement New feature or request and removed bug Something isn't working labels Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant