Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bundler): match on Path::extension instead of using Path::ends_with #11327

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

amrbashir
Copy link
Member

Path::ends_with considers components only when comparing, so if .ico is not a full component of the path, it is not matched, we should use Path::extension instead as Path::ends_with documentation suggests.

…_with`

`Path::ends_with` considers components only when comparing, so if `.ico` is not a full component of the path, it is not matched, we should use `Path::extension` instead as `Path::ends_with` documentation suggests.
@amrbashir amrbashir requested a review from a team as a code owner October 12, 2024 13:18
Copy link
Contributor

Package Changes Through 4cf8f72

There are 6 changes which include tauri with minor, tauri-cli with patch, @tauri-apps/cli with patch, tauri-bundler with patch, tauri-runtime with minor, tauri-runtime-wry with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tauri-bundler 2.0.2 2.0.3
tauri-runtime 2.0.1 2.1.0
tauri-runtime-wry 2.0.1 2.1.0
tauri 2.0.2 2.1.0
@tauri-apps/cli 2.0.2 2.0.3
tauri-cli 2.0.2 2.0.3

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@lucasfernog lucasfernog merged commit 61bffa4 into dev Oct 12, 2024
15 checks passed
@lucasfernog lucasfernog deleted the fix/bundler-endswtith-check branch October 12, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants