Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix incorrect label passed to ipc protocol #11268

Merged
merged 13 commits into from
Oct 12, 2024
Merged

fix: fix incorrect label passed to ipc protocol #11268

merged 13 commits into from
Oct 12, 2024

Conversation

amrbashir
Copy link
Member

closes #11171

@amrbashir amrbashir requested a review from a team as a code owner October 8, 2024 05:05
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024 •
edited
Loading

Package Changes Through 958dad1

There are 6 changes which include tauri with minor, tauri-cli with patch, @tauri-apps/cli with patch, tauri-bundler with patch, tauri-runtime with minor, tauri-runtime-wry with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tauri-bundler 2.0.2 2.0.3
tauri-runtime 2.0.1 2.1.0
tauri-runtime-wry 2.0.1 2.1.0
tauri 2.0.2 2.1.0
@tauri-apps/cli 2.0.2 2.0.3
tauri-cli 2.0.2 2.0.3

Add another change file through the GitHub UI by following this link.

Read about change files or the docs at github.com/jbolda/covector

@amrbashir amrbashir mentioned this pull request Oct 8, 2024
Closed
@lucasfernog
Copy link
Member

needs tauri-apps/wry#1384

lucasfernog
lucasfernog reviewed Oct 11, 2024
View reviewed changes
.changes/incorrect-label-linux-command.md Outdated
@@ -0,0 +1,7 @@
---
"tauri": "minor:bug"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should release it as a patch instead

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tauri-runtime and tauri-runtime-wry probably can keep the minor as it's a breaking change

Copy link
Member Author

@amrbashir amrbashir Oct 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah tauri could probably be patch, updated

@lucasfernog
Copy link
Member

needs wry 0.46 - tauri-apps/wry#1387

@lucasfernog lucasfernog merged commit 2d087ee into dev Oct 12, 2024
22 checks passed
@lucasfernog lucasfernog deleted the fix/fix-ipc-protocol-label branch October 12, 2024 10:46
@github-actions github-actions bot mentioned this pull request Oct 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gschier gschier gschier left review comments

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] broken IPC in multi window app on Linux
3 participants
@amrbashir @lucasfernog @gschier