Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] .ico generated using tauri icon is incompatible when building on Windows. #11220

Closed
ferferga opened this issue Oct 4, 2024 · 1 comment · Fixed by #11315
Closed

[bug] .ico generated using tauri icon is incompatible when building on Windows. #11220

ferferga opened this issue Oct 4, 2024 · 1 comment · Fixed by #11315
Labels
status: needs triage This issue needs to triage, applied to new issues type: bug

Comments

@ferferga
Copy link

ferferga commented Oct 4, 2024

Describe the bug

I generate the icons of my app every time I build it using tauri icon, since I don't want to have lots of assets in my repo's commit history and tauri icon ensures that they're always strictly appropiate for my app.

Although in the command's output its stated that .ico files are generated, building on Windows always fail.

Reproduction

This reproduction was created using create-tauri-app, modifying just the bare minimum to demonstrate the issue (see the commit history for reference:

https://github.com/ferferga/tauri-reproduction-11220

The Windows build log is located in a GitHub Action's run: https://github.com/ferferga/tauri-reproduction-11220/actions/runs/11178007324

Expected behavior

The icons generated by tauri icon work out of the box

Full tauri info output

> tauri-app@0.1.0 tauri
> tauri info


[✔] Environment
    - OS: Debian 12.0.0 x86_64 (X64)
    ✔ webkit2gtk-4.1: 2.44.3
    ✔ rsvg2: 2.54.7
    ✔ rustc: 1.81.0 (eeb90cda1 2024-09-04)
    ✔ cargo: 1.81.0 (2dbb1af80 2024-08-20)
    ✔ rustup: 1.27.1 (54dd3d00f 2024-04-24)
    ✔ Rust toolchain: stable-x86_64-unknown-linux-gnu (default)
    - node: 20.17.0
    - npm: 10.8.2

[-] Packages
    - tauri 🦀: 2.0.1
    - tauri-build 🦀: 2.0.1
    - wry 🦀: 0.44.1
    - tao 🦀: 0.30.3
    - @tauri-apps/api : 2.0.1
    - @tauri-apps/cli : 2.0.1

[-] Plugins
    - tauri-plugin-shell 🦀: 2.0.1
    - @tauri-apps/plugin-shell : 2.0.0

[-] App
    - build-type: bundle
    - CSP: unset
    - frontendDist: ../dist
    - devUrl: http://localhost:1420/
    - bundler: Vite

Stack trace

Compiling open v5.3.0
    Finished `release` profile [optimized] target(s) in 10m 06s
    Built application at: D:\a\tauri-issue\tauri-issue\src-tauri\target\release\tauri-app.exe
thread '<unnamed>' panicked at crates\tauri-cli\src\interface\rust.rs:1227:8:
the bundle config must have a `.ico` icon
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Additional context

There are possibly 2 things failing here:

  • The icons generated are not suitable
  • The glob pattern doesn't work properly in Windows. However, I also tested icons/*.ico without success.

Builds were succeeding in my end before v2 with this setup.

@ferferga ferferga added status: needs triage This issue needs to triage, applied to new issues type: bug labels Oct 4, 2024
@RSS1102

This comment was marked as off-topic.

amrbashir added a commit that referenced this issue Oct 11, 2024
lucasfernog added a commit that referenced this issue Oct 12, 2024
…MSI installer (#11315)

* fix(cli): resolve `bundle > icon` glob when searching for `.ico` for MSI installer

closes #11220

* Update crates/tauri-bundler/src/bundle/settings.rs

Co-authored-by: Lucas Fernandes Nogueira <lucas@tauri.app>

* Update crates/tauri-bundler/src/bundle/windows/msi/mod.rs

Co-authored-by: Lucas Fernandes Nogueira <lucas@tauri.app>

* Update crates/tauri-bundler/src/bundle/windows/msi/mod.rs

Co-authored-by: Lucas Fernandes Nogueira <lucas@tauri.app>

---------

Co-authored-by: Lucas Fernandes Nogueira <lucas@tauri.app>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs triage This issue needs to triage, applied to new issues type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants