Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sort order of test result ascending #83

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

tasshi-me
Copy link
Owner

@tasshi-me tasshi-me commented Aug 16, 2022

Why

I merged #68 but some tests slipped through the status check and fail now.

Also, I want to change the sort order of test results to ascending.

What

  • make sort order of test result asc
  • fix tests

@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #83 (c1a8c33) into main (8e6d584) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
+ Coverage   93.33%   93.39%   +0.05%     
==========================================
  Files           5        5              
  Lines         345      348       +3     
  Branches       67       68       +1     
==========================================
+ Hits          322      325       +3     
  Misses         23       23              
Impacted Files Coverage Δ
src/dashboard/converter.ts 94.81% <100.00%> (+0.11%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tasshi-me tasshi-me changed the title fix: make sort order of test result asc fix: make sort order of test result ascending Aug 16, 2022
@tasshi-me tasshi-me merged commit cbb5475 into main Aug 16, 2022
@tasshi-me tasshi-me deleted the fix/test-result-sort-order branch August 16, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant