Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proper way to get version #2861

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Conversation

manast
Copy link
Contributor

@manast manast commented Oct 23, 2024

No description provided.

Copy link
Collaborator

@roggervalf roggervalf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@manast
Copy link
Contributor Author

manast commented Oct 24, 2024

Merging even though node@current (NodeJS v23) is not passing the tests due to bugs in Node itself. All LTS versions are green and those are the ones we should care about.

@manast manast merged commit 99f95b6 into v4.x Oct 24, 2024
8 of 9 checks passed
@manast manast deleted the fix/proper-way-to-get-version-v4 branch October 24, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants