Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: spawn-wrap@1.4.0 creates undefined folder #64

Closed
bcoe opened this issue Oct 22, 2017 · 7 comments
Closed

bug: spawn-wrap@1.4.0 creates undefined folder #64

bcoe opened this issue Oct 22, 2017 · 7 comments

Comments

@bcoe
Copy link
Member

bcoe commented Oct 22, 2017

I've been doing some testing with spawn-wrap@1.4.0 with nyc. I'm noticing that an undefined folder is created whenever spawn-wrap is executed. I'm guessing this is related to the mkdirp logic that was introduced to create working directories.

CC: @chadxz, @gautaz

@chadxz
Copy link
Contributor

chadxz commented Oct 23, 2017

I can reproduce that issue with nyc

@chadxz
Copy link
Contributor

chadxz commented Oct 23, 2017

it's because https://github.com/tapjs/spawn-wrap/blob/master/index.js#L15 should say home + instead of homedir +. Will post a PR

@czy88840616
Copy link

have some publish plan for this patch ?

@guangwong
Copy link

+1

@we11adam
Copy link

@bcoe can we publish a 1.4.1 release to include this fix, please?

@bcoe
Copy link
Member Author

bcoe commented Nov 16, 2017

@isaacs mind publishing a patch release when you have a moment; this will stop a bug that's creating the scripts directory in the wrong location.

@isaacs
Copy link
Collaborator

isaacs commented Nov 16, 2017

fixed on 1.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants