feat: progress logging #290
Open
+250
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endbr64
force-pushed
the
progress_logging
branch
from
68d6c28
to
0ac6db7
Compare
endbr64
commented
Oct 19, 2024
| let this = self.get_mut(); | ||
| let poll_result = Pin::new(&mut this.inner).poll_read(cx, buf); | ||
| if let std::task::Poll::Ready(Ok(())) = &poll_result { | ||
| let read_bytes = buf.filled().len() as u64; |
There was a problem hiding this comment.
This is ugly because we also keep track of progress in consume() below. In practice, we always use one or the other in extract/(de)compress. Taking suggestions on how to improve this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.