Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support English #227

Open
omaryasser opened this issue May 12, 2021 · 0 comments
Open

Support English #227

omaryasser opened this issue May 12, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@omaryasser
Copy link
Collaborator

omaryasser commented May 12, 2021

A lot of users will benefit from supporting English ❤️

We started coding the application with supporting multiple languages in mind. That's why we introduced app_localizations.dart, in which we used to save all strings.

Then after realizing that we will not work on supporting English soon, we decided to inline Arabic text directly in code without adding it into app_localizations.dart.

If you will work on this, you will at least need to:

  • Decide on the way with which users will switch the language
  • Decide on the mechanism with which you will do that in code (i.e. that can already be done using the app_localizations.dart file).
  • Remove all inlined Arabic text and add a variable instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant