-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Command client pre-phrase signal #676
Conversation
Overall I think it looks good |
@@ -357,6 +358,14 @@ def trigger_command_server_command_execution(): | |||
was written to the file. For internal use only""" | |||
actions.key("ctrl-shift-f17") | |||
|
|||
def emit_pre_phrase_signal(): | |||
"""Touches a file to indicate that a phrase is about to begin execution""" | |||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect that return None
would work here to make Talon think this method is implemented. Probably want a comment explaining that we're deliberately creating a no-op action, not an unimplemented action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a comment to the global scope implementation. I think I'd lean towards keeping that impl; otherwise it feels like we're trying to trick Talon's static analysis
Touches a file known to the VSCode command server before executing any phrase, to allow VSCode extensions to detect start of phrase and maintain consistency over the course of a phrase.
Inaugural use case is allowing cursorless to freeze a snapshot of the hats so that they don't shift over the course of a single command phrase (cursorless-dev/cursorless#318)