override edit.selected_text (preserve/restore selection after copy) #1556
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For quite a while, have been annoyed by homophone selection (specifically
phones word
) not working inemacs
. I finally tracked this down to the following issue: the call toselected_text
inside ofuser.homophones_show_selection
actually clears the selection. As a consequence, "choose" appends the selected homophone to the original word, instead of replacing it.Clearing the selection is the expected behavior when copying in
emacs
, but this changesselected_text
to restore the selection after copying.Note: This still requires enabling
delete-selection-mode
, but I would deem that acceptable when editing natural language text.Context: