Code cleanup for held mouse buttons #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # Start drag | ||
| ctrl.mouse_click(button=button, down=True) | ||
|
|
||
| def mouse_drag_end(): | ||
| """Releases any held mouse buttons""" | ||
| buttons_held_down = list(ctrl.mouse_buttons_down()) | ||
| for button in buttons_held_down: | ||
| for button in ctrl.mouse_buttons_down(): |
There was a problem hiding this comment.
ctrl.mouse_buttons_down() returns set[int]. No need to wrap in a list.
| @@ -151,11 +150,7 @@ def mouse_sleep(): | |||
|
|
|||
| show_cursor_helper(True) | |||
| stop_scroll() | |||
|
|
|||
| # todo: fixme temporary fix for drag command | |||
| button_down = len(list(ctrl.mouse_buttons_down())) > 0 | |||
There was a problem hiding this comment.
This is basically a recreation of the logic in mouse_drag_end, but worse.
| @@ -132,15 +132,14 @@ def mouse_wake(): | |||
| def mouse_drag(button: int): | |||
| """Press and hold/release a specific mouse button for dragging""" | |||
| # Clear any existing drags | |||
| self.mouse_drag_end() | |||
There was a problem hiding this comment.
I was surprised this even worked. We should definitely call Talon actions through the action interface.
AndreasArvidsson
changed the title
nriley
approved these changes
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.