-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a please action for use in command palettes and the like #1536
Comments
I'm suspicious that there may be some valid reasons to diverge (if the please behavior is to automatically trigger, chaining might be possible). But just to understand clearly, what is the ask here? |
Either change all the please implementations to anchor, or implement please once with an action overridden in each app's context. The same voice command should not be anchored differently across apps. |
I can do that. I was trying to target my original fix to just where I was feeling pain since I'm not sure how it will impact others (since I'm not using please elsewhere). I'll update the PR to accommodate this additional requirement. |
To avoid divergence in the grammar for please commands, it is useful to define a centralized tag and allow it to be overridden in command implementations. Addresses #1536
This voice command is defined in many places in community already, and with changes like #1534 these implementations can drift from one another.
The text was updated successfully, but these errors were encountered: