Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using mouseup for closeOnOutsideClick behaviour is troublesome #149

Closed
mateomurphy opened this issue May 9, 2017 · 3 comments
Closed

using mouseup for closeOnOutsideClick behaviour is troublesome #149

mateomurphy opened this issue May 9, 2017 · 3 comments
Labels
bug
Milestone
v4

Comments

@mateomurphy
Copy link

Using mouseup means that clicking inside the modal, dragging out, and releasing closes the modal. This is a pretty common occurrence using modals for forms.

I understand that mouseup was used to solve #65 , was using click not an option?
@mufasa71
Copy link

Any updates on this?

@mateomurphy
Copy link
Author

Hi, I'm sorry I didn't get a notification for your commit, I will test it out this week!

@tajo tajo added this to the v4 milestone Jul 29, 2017
@tajo tajo added the bug label Jul 29, 2017
@tajo
Copy link
Owner

tajo commented Oct 1, 2017

Hey, please check the new major version of react-portal: #157

It's React v16 only since its uses the new official Portal API. There is the first beta released and I would like to get your feedback. I don't have bandwidth to maintain v3 which is very different and full of hacks.

I am happy to discuss this with v4 in mind.

@tajo tajo closed this as completed Oct 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v4
Development

No branches or pull requests
3 participants
@mateomurphy @mufasa71 @tajo