Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portal contents re-mount when unmount triggers an update #145

Closed
smably opened this issue Apr 12, 2017 · 2 comments
Closed

Portal contents re-mount when unmount triggers an update #145

smably opened this issue Apr 12, 2017 · 2 comments
Labels
Milestone

Comments

@smably
Copy link

smably commented Apr 12, 2017

If the portal contents trigger an update on componentWillUnmount, the contents of the portal will re-mount after unmount. See test case: https://gist.github.com/smably/7550b9451682ff533b749f24aa57ca23

In the console:
screen shot 2017-04-12 at 2 36 44 pm

I would expect that after the portal closes, it remains closed until re-opened by normal means.

@dwick
Copy link

dwick commented Apr 20, 2017

i think this is the same issue fixed in #124

@tajo tajo added the bug label Jul 29, 2017
@tajo tajo added this to the v4 milestone Jul 29, 2017
@tajo
Copy link
Owner

tajo commented Oct 1, 2017

Hey, please check the new major version of react-portal: #157

It's React v16 only since its uses the new official Portal API. There is the first beta released and I would like to get your feedback. I don't have bandwidth to maintain v3 which is very different and full of hacks.

I am happy to discuss this with v4 in mind.

@tajo tajo closed this as completed Oct 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants