Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSSPropertyOperations moved to react-dom #103

Closed
bsr203 opened this issue Oct 14, 2016 · 7 comments
Closed

CSSPropertyOperations moved to react-dom #103

bsr203 opened this issue Oct 14, 2016 · 7 comments

Comments

@bsr203
Copy link

bsr203 commented Oct 14, 2016

Hi,

I noticed that CSSPropertyOperations has been moved to react-dom. so only change needed for me was at

import CSSPropertyOperations from 'react/lib/CSSPropertyOperations';
to

import CSSPropertyOperations from 'react-dom/lib/CSSPropertyOperations';

ref: facebook/react#7770 (comment)

@gaearon
Copy link

gaearon commented Oct 14, 2016

Please note that React does not officially support importing these modules at all. Instead of changing the path we encourage you to inline the code you rely on.

@hellatan
Copy link

i posted this comment in an older issue, but I figured it would be better add it here instead:

this is an issue with react and the related packages bumping to 15.4.0 today.

I downgraded all of these packages:

npm install react@15.3.0 react-dom@15.3.0 react-addons-css-transition-group@15.3.0  react-addons-test-utils@15.3.0 react-addons-update@15.3.0

and this error went away.

@gaearon
Copy link

gaearon commented Nov 16, 2016

To be clear the issue is not with React. It is with libraries that import internal modules from React which was never supported. Please check out the release notes.

The fix is for authors of react-portal to embed the internal code they rely on. We don't promise that those modules will stay in the same place in future versions of React.

@daltones
Copy link

See #105

@tajo
Copy link
Owner

tajo commented Nov 16, 2016

Yep, @gaearon is correct. This is not React's fault. All internal modules from React were removed, so future minor versions of React should not break this module. Thanks!

@tajo tajo closed this as completed Nov 16, 2016
@gaearon
Copy link

gaearon commented Nov 17, 2016

Thanks for quick response!

@amitksingh1490
Copy link

for the temporary fix, I added below library in my dependencies "only-react-css-property-operations": "^1.0.1". It fixed the issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants