Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with PSE main #8

Closed
wants to merge 28 commits into from
Closed

Conversation

mratsim
Copy link

@mratsim mratsim commented Jun 20, 2023

This brings in 2 changes from PSE main.

  1. feat: send sync region privacy-scaling-explorations/halo2#180
    This adds parallelized RegionLayouter, see discussion Send and Sync Region  privacy-scaling-explorations/halo2#173
    To scale to hundreds of millions of constraints for provable ML.
    This may conflict with Resolve Prover optimization: memory reduction #77 #6, cc @einar-taiko
  2. Fix parallelize workload imbalance privacy-scaling-explorations/halo2#186
    This is a self-contained change to parallelize, see Fix parallelize workload imbalance #7

alexander-camuto and others added 28 commits June 1, 2023 10:22
* feat: send / sync region

* Update layout.rs

* update

* lol

* debug

* Update keygen.rs

* Update keygen.rs

* Update keygen.rs

* Update keygen.rs

* thread-safe-region feature flag

* cleanup

* patch dev-graph

* patch non-determinism in mapping creation

* reduce mem usage for vk and pk

* mock proving examples

* swap for hashmap for insertion speed

* reduce update overhead

* replace BTree with Vec

* add benchmarks

* make the benchmarks massive

* patch clippy

* simplify lifetimes

* patch benches

* Update halo2_proofs/src/plonk/permutation/keygen.rs

Co-authored-by: Han <tinghan0110@gmail.com>

* Update halo2_proofs/examples/vector-mul.rs

Co-authored-by: Han <tinghan0110@gmail.com>

* rm benches

* order once

* patch lints

---------

Co-authored-by: Han <tinghan0110@gmail.com>
* fix parallelize workload imbalance

* remove the need of unsafe
Implement native shuffle argument and api
…192)

* feat: public cells

* Update mds.rs

* Update mds.rs

* Update single_pass.rs

Co-authored-by: Han <tinghan0110@gmail.com>

* bump toolchain to resolve errors

* fix clippy errors for CI run

* rustfmt post clippy

* plz let it be the last lint

* patch clippy lints in gadgets

* clippy lints for sha256 bench

* patch halo2proof benches

* Update assigned.rs

* Update halo2_gadgets/src/poseidon/primitives/mds.rs

Co-authored-by: Han <tinghan0110@gmail.com>

* Update halo2_gadgets/src/poseidon/primitives/mds.rs

Co-authored-by: Han <tinghan0110@gmail.com>

---------

Co-authored-by: Han <tinghan0110@gmail.com>
* fix: explicitly define mds diff type

* rm paren
* refactor: add default impl for `SyncDeps` for backward compatability

* feat: pick changes from zcash#728 and changes of flag `test-dev-graph`

* feat: pick changes from zcash#622

* feat: pick changes about mod `circuit` and mod `dev`

* feat: pick rest changes of `halo2_proofs`

* fix: when `--no-default-features`

* ci: sync from upstream, and deduplicate jobs when
push to `main`, and remove always failing job `codecov`.

* fix: make `commit_zk` runnable when `--no-default-features`
* chore: Update rust-toolchain to 1.66 for testing

Note that tests will not compile due to the silent MSRV bump in
`blake2b_simd`.

Hence, we need to use `1.66` as toolchain.

Resolves: #207

* change: UIpdate MSRVs in Cargo.toml
* fix: clippy

* fmt

* fix: Final clippy complains & adjustments

---------

Co-authored-by: CPerezz <c.perezbaro@gmail.com>
* improve root calculation for KZG setup()

* Update halo2_proofs/src/poly/kzg/commitment.rs

Co-authored-by: Han <tinghan0110@gmail.com>

* Fix rust format issue

---------

Co-authored-by: Han <tinghan0110@gmail.com>
* Make it Eq to make it easier for tests

* Implement Sum and Product for Expression

* Make it readable
@mratsim
Copy link
Author

mratsim commented Oct 11, 2023

closing, reorganizing the repo branch-wise

@mratsim mratsim closed this Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.