You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The cargo msrv verification fails since some dependency requires once_cell. The github action does not find this as it doesn't actually use cargo-msrv to find the msrv. The action only seems to verify that cargo check works on the currently defined toolchain that is installed (1.52 right now). I am not sure why that works on 1.52 when cargo msrv verify reports that 1.52 doesn't work when the cargo check in the action environment seems to work. I think this may have something to do with some deps requiring wasm support, but I'm not totally sure if that's the key.
I recommend that we change the action to use the cargo msrv verify to verify the version. If that verification fails, we can run cargo msrv search process to find the actual MSRV.
If this sounds reasonable, I can help implement such a thing.
FWIW, the current true MSRV is 1.60 when running cargo msrv.
Here's an example of the output from cargo msrv --output-format json verify:
The only required dependency is memchr and our MSRV restricted only by it. Actually, we use some features (I don't mean cargo features here) that requires 1.52. But enabling some cargo features, async-tokio for example, indeed increases MSRV.
cargo tree does not show once_cell in our dependency tree (which includes dependencies when all features is enabled), so I think this is an error of cargo msrv command. Probably this is dependency of one of examples, which, of course, not is a dependency of a crate itself.
The cargo msrv verification fails since some dependency requires once_cell. The github action does not find this as it doesn't actually use cargo-msrv to find the msrv. The action only seems to verify that cargo check works on the currently defined toolchain that is installed (1.52 right now). I am not sure why that works on 1.52 when
cargo msrv verify
reports that 1.52 doesn't work when thecargo check
in the action environment seems to work. I think this may have something to do with some deps requiring wasm support, but I'm not totally sure if that's the key.I recommend that we change the action to use the
cargo msrv verify
to verify the version. If that verification fails, we can runcargo msrv
search process to find the actual MSRV.If this sounds reasonable, I can help implement such a thing.
FWIW, the current true MSRV is 1.60 when running
cargo msrv
.Here's an example of the output from
cargo msrv --output-format json verify
:Here's part of the output of
cargo msrv --output-format json verify | jq -r 'select(.version == "1.57.0")'
:The text was updated successfully, but these errors were encountered: