feat: use expo-linking to construct urls for expo auth #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusmarminge
force-pushed
the
11-02-feat_expo_auth
branch
from
993e913
to
cf7338a
Compare
juliusmarminge
force-pushed
the
11-02-feat_expo_auth
branch
from
cf7338a
to
6615bba
Compare
juliusmarminge
force-pushed
the
11-02-feat_expo_auth
branch
from
6615bba
to
5a21451
Compare
juliusmarminge
changed the title
juliusmarminge
merged commit 83980ab
into
t3-oss:11-02-feat_expo_auth
3 of 5 checks passed
|
|
||
| const authResponse = await _GET(req); | ||
| const authResponse = await DEFAULT_GET(req); | ||
| const setCookie = authResponse.headers.getSetCookie()[0]; |
There was a problem hiding this comment.
I was trying to use this solution with Google and it didn't work, after some debugging it turned out this cookie is actually at index 1, so I think this part needs to be a find or something
juliusmarminge
added a commit
that referenced
this pull request
Jun 9, 2024
* feat: expo auth * rm * fix format * fix lock * feat: use expo-linking to construct urls for expo auth (#832) * expo install --fix * nit * fix cookie * use sync session store api * add custom handler back * fix exports * Use .find() instead of always first cookie (#1043) * feat: Expo Auth without setting AUTH_URL. (#1054) * feat: expo-auth without auth_url env var * Fix session cookie matching * feat: Restore old CSRF checks in non-dev environments * chore: Documenting some decisions with comments * Use node env instead of vercel-specific env var * Update readme to describe oauth changes * Fix redirectTo being missing and enforce home nav since it was showing a weird page * Disallow backwards navigation upon auth change * some light refactoring * dont' mutate args * helper * cmt * fmt --------- Co-authored-by: Jay McMullen <j@1f.io> Co-authored-by: Gabriel Bianchi <gdbianchii@gmail.com> Co-authored-by: Sam Riddle <Wundero@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds compatibility for Next-Auth/Authjs with the Expo app.
Thanks to @juliusmarminge for doing most of the work in #720.
Closes #486
In order to get it working locally, you will need to set the AUTH_URL environment variable to your local IP address instead of localhost otherwise CRSF errors will be encountered. This isn't a massive concern since you will need to edit the baseUrl logic before deploying to production anyway.
Demo:
Simulator.Screen.Recording.-.Development.-.2024-01-05.at.20.15.23.mp4