Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment: attempt to restore Travis CI #93

Merged
merged 5 commits into from
Mar 3, 2021
Merged

Experiment: attempt to restore Travis CI #93

merged 5 commits into from
Mar 3, 2021

Conversation

jayaddison
Copy link
Contributor

What's the problem this PR addresses?
Continuous integration via Travis seems broken at the moment; see this example build log from pull request #92.

The problem is potentially due to over-escaping of the before_script commands, based on the observed output:

The command "yarn add -D webpack@$WEBPACK_VERSION" failed and exited with 1 during .

Before opening and/or merging further changes it'd be good to get tests green again.

How did you fix it?
This isn't yet a confirmed fix; but the approach taken is to remove the outer double-quotes from the command specification.

… by removing over-escaping of before_script commands
@jayaddison
Copy link
Contributor Author

Aha: the problem may was within one of the nested build output steps:

[noisy start-of-line removed] ... provides eslint@npm:6.8.0 with version 6.8.0 which doesn't satisfy ^4.9.0 requested by eslint-config-airbnb-base@npm:12.1.0

So updating and/or tuning a few of the package.json dependency references may resolve this.

…allation by removing over-escaping of before_script commands"

This reverts commit 6be2bdd.
@jayaddison
Copy link
Contributor Author

NB: There are other dependency updates that could be beneficial to apply; the goal in this pull request is to get continuous integration working again first, and then dependency freshness can be applied as a subsequent set of changes.

@jayaddison
Copy link
Contributor Author

Nope, it's been a long day. The eslint messages are warnings, not errors. The error line appears to be:

fsevents@patch:fsevents@npm%3A2.3.2#builtin<compat/fsevents>::version=2.3.2&hash=127e8e: Cannot apply hunk #1 (set enableInlineHunks for details)

This has been resolved in another codebase by upgrading the Yarn version registreerocks/registree-core#370 . In the builds for this repository we are dependent on the underlying OS environment.

Can/should we upgrade the Yarn version within the CI container, either by selecting a more up-to-date environment, or by performing a runtime upgrade?

@jayaddison
Copy link
Contributor Author

cc @larixer

@larixer larixer merged commit 6240eeb into sysgears:master Mar 3, 2021
@larixer
Copy link
Member

larixer commented Mar 3, 2021

Looks good to me, thank you!

@jayaddison jayaddison deleted the experiment/travis-ci-escaping branch March 3, 2021 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants