Fix --file not being respected #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any files that were added via --file were being blown away when Webpack's entrypoints were being added. In order to resolve this, the entrypoints now get added via Mocha's addFile method. Closes #20 Signed-off-by: Will <will-soto@pluralsight.com>
|
@willsoto Nice, many thanks! |
|
Published in |
|
Thanks for the quick review and release! |
|
@larixer It doesn't seem like the change made it into
|
|
@willsoto Could you check if it came through into Yarn 2 does not use |
|
@larixer - works now. Thank you very much! |
|
@willsoto Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
--filenot being respectedHow did you fix it?
Any files that were added via --file were being blown away when Webpack's entrypoints were being added.
In order to resolve this, the entrypoints now get added via Mocha's addFile method.
Closes #20