Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade chokidar dep #101

Merged
merged 1 commit into from
May 25, 2021
Merged

Upgrade chokidar dep #101

merged 1 commit into from
May 25, 2021

Conversation

nVitius
Copy link
Contributor

@nVitius nVitius commented May 24, 2021

Chokidar v3 has been out for just over three years now.
It includes some major performance improvements and a fully backwards-compatible API. The only exception being that it drops support for node versions prior to v8.

I'm sure lots of people would be happy to see the deprecation warnings go away when installing a project that depends on this (in my case, it's the Vue plugin for mocha).

@nVitius
Copy link
Contributor Author

nVitius commented May 24, 2021

If there are any considerations around merging and releasing this change. Let's talk about them here. :)

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2021

Codecov Report

Merging #101 (0c4f633) into master (70bb519) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #101   +/-   ##
=======================================
  Coverage   60.93%   60.93%           
=======================================
  Files          44       44           
  Lines        1349     1349           
  Branches      158      158           
=======================================
  Hits          822      822           
  Misses        509      509           
  Partials       18       18           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70bb519...0c4f633. Read the comment docs.

@larixer larixer merged commit a2af423 into sysgears:master May 25, 2021
@larixer
Copy link
Member

larixer commented May 25, 2021

@nVitius Thank you! Published in mochapack@2.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants