fix: add support for no colors mode #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #359 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 957 992 +35
=========================================
+ Hits 957 992 +35 |
noahnu
reviewed
Sep 19, 2020
| | `--snapshot-update` | Snapshots will be updated to match assertions and unused snapshots will be deleted. | `False` | | ||
| | `--snapshot-warn-unused` | Prints a warning on unused snapshots rather than fail the test suite. | `False` | | ||
| | `--snapshot-default-extension` | Use to change the default snapshot extension class. | `syrupy.extensions.amber.AmberSnapshotExtension` | | ||
| | `--snapshot-no-colors` | Disable test results output highlighting. Equivalent to setting the environment variables `ANSI_COLORS_DISABLED` or `NO_COLOR` | Disabled by default if not in terminal. | |
There was a problem hiding this comment.
Does pytest also natively support ANSI_COLORS_DISABLED?
There was a problem hiding this comment.
pytest supports by default
NO_COLOR
So added both
noahnu
approved these changes
Sep 19, 2020
|
|
||
|
|
||
| def _is_color_disabled() -> bool: | ||
| return any(map(get_env_value, DISABLE_COLOR_ENV_VARS)) |
There was a problem hiding this comment.
I'm fine with this (and actually prefer it) but I thought we had a lint rule around preferring comprehension over map/reduce etc
There was a problem hiding this comment.
I don't think there's a lint rule around it, just a general case by case basis imo
syrupy-bot
pushed a commit
that referenced
this pull request
Sep 20, 2020
## [0.7.2](v0.7.1...v0.7.2) (2020-09-20) ### Bug Fixes * add support for no colors mode ([#359](#359)) ([ec39b80](ec39b80))
|
🎉 This PR is included in version 0.7.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support no colors mode with environment variables
NO_COLOR,ANSI_COLORS_DISABLEDor pytest option.Related Issues
Checklist
Additional Comments
NO_COLOR