-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maintenace(synapse-interface): display remaining days #3070
Conversation
WalkthroughThe changes enhance the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- packages/synapse-interface/components/Maintenance/components/EventCountdownProgressBar.tsx (1 hunks)
Additional comments not posted (2)
packages/synapse-interface/components/Maintenance/components/EventCountdownProgressBar.tsx (2)
25-31
: LGTM!The addition of
daysRemaining
to the destructured variables is correct and aligns with the updated logic for calculating thetimeRemaining
string.The code changes are approved.
36-38
: LGTM!The updated logic for calculating the
timeRemaining
string is correct and improves the user interface by providing a more granular view of the countdown.The code changes are approved.
Deploying sanguine-fe with Cloudflare Pages
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3070 +/- ##
=============================================
Coverage 33.92610% 33.92610%
=============================================
Files 513 513
Lines 31828 31828
Branches 82 82
=============================================
Hits 10798 10798
Misses 20061 20061
Partials 969 969
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Bundle ReportChanges will increase total bundle size by 9.3MB ⬆️
|
Summary by CodeRabbit
9b0bd8f: synapse-interface preview link