Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintenace(synapse-interface): display remaining days #3070

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

bigboydiamonds
Copy link
Collaborator

@bigboydiamonds bigboydiamonds commented Aug 27, 2024

Summary by CodeRabbit

  • New Features
    • Enhanced countdown progress bar to display days remaining in addition to hours and minutes.
    • Improved user interface for a more informative countdown experience.

9b0bd8f: synapse-interface preview link

Copy link
Contributor

coderabbitai bot commented Aug 27, 2024

Walkthrough

The changes enhance the useEventCountdownProgressBar function in EventCountdownProgressBar.tsx by adding daysRemaining to its logic, allowing for a more detailed countdown display. The calculation of the timeRemaining string has been updated to prioritize days when applicable, improving the overall countdown functionality without altering any exported or public entity declarations.

Changes

Files Change Summary
packages/synapse-interface/components/Maintenance/components/EventCountdownProgressBar.tsx Enhanced useEventCountdownProgressBar function by adding daysRemaining and modifying timeRemaining string logic for improved countdown display.

Poem

🐰 In a world where time does play,
The countdown ticks, both night and day.
With days and hours, we now can see,
A clearer path for you and me!
So hop along, let’s count the cheer,
For every moment, we hold dear! 🎉


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between fca6b36 and d8203d6.

Files selected for processing (1)
  • packages/synapse-interface/components/Maintenance/components/EventCountdownProgressBar.tsx (1 hunks)
Additional comments not posted (2)
packages/synapse-interface/components/Maintenance/components/EventCountdownProgressBar.tsx (2)

25-31: LGTM!

The addition of daysRemaining to the destructured variables is correct and aligns with the updated logic for calculating the timeRemaining string.

The code changes are approved.


36-38: LGTM!

The updated logic for calculating the timeRemaining string is correct and improves the user interface by providing a more granular view of the countdown.

The code changes are approved.

Copy link

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: d8203d6
Status: ✅  Deploy successful!
Preview URL: https://5ec557b1.sanguine-fe.pages.dev
Branch Preview URL: https://maintenance-display-days-lef.sanguine-fe.pages.dev

View logs

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.92610%. Comparing base (e61e1bf) to head (d8203d6).
Report is 4 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##              master       #3070   +/-   ##
=============================================
  Coverage   33.92610%   33.92610%           
=============================================
  Files            513         513           
  Lines          31828       31828           
  Branches          82          82           
=============================================
  Hits           10798       10798           
  Misses         20061       20061           
  Partials         969         969           
Flag Coverage Δ
packages 90.56974% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bigboydiamonds bigboydiamonds merged commit 6d971c2 into master Aug 27, 2024
38 checks passed
@bigboydiamonds bigboydiamonds deleted the maintenance/display-days-left branch August 27, 2024 17:08
Copy link

codecov bot commented Aug 27, 2024

Bundle Report

Changes will increase total bundle size by 9.3MB ⬆️

Bundle name Size Change
sdk-router-@synapsecns/sdk-router-esm 254.97kB 0 bytes
sdk-router-@synapsecns/sdk-router-cjs 117.25kB 0 bytes
explorer-ui-server-cjs 865.78kB 0 bytes
explorer-ui-edge-server-array-push 83 bytes 0 bytes
explorer-ui-client-array-push 2.31MB 0 bytes
synapse-interface-edge-server-array-push 83 bytes 83 bytes ⬆️
synapse-interface-server-cjs 1.33MB 1.33MB ⬆️
synapse-interface-client-array-push 7.41MB 7.41MB ⬆️
widget-cjs-esm 278.45kB 278.45kB ⬆️
widget-esm-cjs 280.44kB 280.44kB ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants