Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy #2875

Merged
merged 3 commits into from
Jul 16, 2024
Merged

deploy #2875

merged 3 commits into from
Jul 16, 2024

Conversation

trajan0x
Copy link
Contributor

@trajan0x trajan0x commented Jul 16, 2024

Description

deploy to fe-release

Summary by CodeRabbit

  • New Features

    • Introduced the LifiPage component to manage Li.fi approvals across multiple chains, allowing users to view and revoke ERC20 token approvals.
  • Dependency Updates

    • Updated @synapsecns/sdk-router to version 0.8.0 across several packages.
    • Increased versions for @synapsecns/rest-api, @synapsecns/synapse-interface, and @synapsecns/widget to match dependency updates.
  • Enhancements

    • Added BSC support in the SDK for RFQ features, improving cross-chain functionality.

466ba94: synapse-interface preview link

abtestingalpha and others added 3 commits July 15, 2024 12:58
* Adds BSC to RFQ

* swaps out bsc for arb in test
 - @synapsecns/rest-api@1.0.67
 - @synapsecns/sdk-router@0.8.0
 - @synapsecns/synapse-interface@0.28.1
 - @synapsecns/widget@0.6.1
* Init lifi approval revoke page

* get rid of victim address and use connected address

* Add some text

* Only show approval data once connected

* Multi-chain checker
Copy link
Contributor

coderabbitai bot commented Jul 16, 2024

Warning

Rate limit exceeded

@github-actions[bot] has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 25 minutes and 21 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 7ec3fc5 and 9a84556.

Walkthrough

The updates primarily involve version increments and the addition of BSC support to the SDK. Version changes affect several packages (@synapsecns/rest-api, @synapsecns/sdk-router, @synapsecns/synapse-interface, @synapsecns/widget) to ensure compatibility. A new feature includes integrating BSC into RFQ. Tests and a new React component (LifiPage) are also updated to support these changes.

Changes

File Summary of Changes
packages/rest-api/CHANGELOG.md, packages/rest-api/package.json Version bump from 1.0.66 to 1.0.67. Updated @synapsecns/sdk-router dependency from ^0.7.1 to ^0.8.0.
packages/sdk-router/CHANGELOG.md, packages/sdk-router/package.json Added BSC support to RFQ, version bump from 0.7.1 to 0.8.0.
packages/sdk-router/src/constants/chainIds.ts Added SupportedChainId.BSC to RFQ_SUPPORTED_CHAIN_IDS.
packages/sdk-router/src/constants/medianTime.ts Added median time value for SupportedChainId.BSC.
packages/sdk-router/src/sdk.test.ts Adjusted tests to replace BSC with ARBITRUM for certain identifiers and providers.
packages/synapse-interface/CHANGELOG.md, packages/synapse-interface/package.json Version bump from 0.28.0 to 0.28.1, updated @synapsecns/sdk-router dependency from ^0.7.1 to ^0.8.0.
packages/synapse-interface/pages/lifi/index.tsx Introduced new LifiPage component for managing token approvals across multiple chains.
packages/widget/CHANGELOG.md, packages/widget/package.json Version bump from 0.6.0 to 0.6.1, updated @synapsecns/sdk-router dependency from ^0.7.1 to ^0.8.0.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant LifiPage
    participant SynapseSDK
    participant Blockchain

    User->>+LifiPage: Open LifiPage
    LifiPage->>+SynapseSDK: Get token allowances
    SynapseSDK->>+Blockchain: Fetch allowances for tokens
    Blockchain-->>-SynapseSDK: Return allowances
    SynapseSDK-->>-LifiPage: Provide token allowance details
    LifiPage-->>User: Display token allowances

    User->>+LifiPage: Revoke token approval
    LifiPage->>+SynapseSDK: Revoke token approval
    SynapseSDK->>+Blockchain: Submit revoke transaction
    Blockchain-->>-SynapseSDK: Confirmation of revocation
    SynapseSDK-->>-LifiPage: Inform about revocation success
    LifiPage-->>User: Display revocation success
Loading

Poem

In the code, a change so bright,
BSC joins the RFQ light.
Versions climb, dependencies new,
Tokens approved, revocations too.
Synapse flows in harmony,
A dance of tech, for all to see.
🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@trajan0x trajan0x merged commit d7c4e0d into fe-release Jul 16, 2024
30 of 31 checks passed
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Updated packages/rest-api/package.json to bump version to 1.0.67 and update @synapsecns/sdk-router dependency to ^0.8.0.
  • Added BSC to RFQ in packages/sdk-router/src/constants/chainIds.ts.
  • Updated packages/sdk-router/src/constants/medianTime.ts to include BSC with a median time of 15 seconds.
  • Modified packages/sdk-router/src/sdk.test.ts to replace BSC with ARBITRUM in tests.
  • Introduced packages/synapse-interface/pages/lifi/index.tsx for revoking token approvals for the Li.fi protocol.

11 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings

@@ -0,0 +1,147 @@
import Grid from '@tw/Grid'
import { useEffect, useState } from 'react'
import { useAccount, useAccountEffect, useSwitchChain } from 'wagmi'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style: The useAccountEffect import is unused and can be removed.

>
<div className="pb-3 place-self-center">
<div>
<h3>Li.fi / Jumper is investigating an ongoing exploit, and users should revoke approvals <a className="underline" target="_blank" href="https://x.com/lifiprotocol/status/1813196697641570635">- Li.fi Tweet</a></h3>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling: The URL in the anchor tag should be updated to a valid link. The current link to 'x.com' is likely incorrect.

@coderabbitai coderabbitai bot mentioned this pull request Sep 26, 2024
@coderabbitai coderabbitai bot mentioned this pull request Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants