Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[goreleaser] Fix: gas value check only for non-in-flight requests #2496

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

ChiTimesChi
Copy link
Collaborator

@ChiTimesChi ChiTimesChi commented Apr 13, 2024

Description
A clear and concise description of the features you're adding in this pull request.

Additional context
Add any other context about the problem you're solving.

Metadata

  • Fixes #[Link to Issue]

Summary by CodeRabbit

  • Bug Fixes
    • Improved the accuracy of gas value calculations for in-flight requests based on their statuses.

Copy link
Contributor

coderabbitai bot commented Apr 13, 2024

Walkthrough

The update in the statushandler.go file enhances how gas values are managed by adjusting inventory deductions based on the status of requests. This ensures more accurate tracking and handling of in-flight requests, optimizing resource usage.

Changes

File Path Summary of Changes
.../rfq/relayer/service/statushandler.go Updated logic for gas value checks by deducting amounts from inventory for in-flight requests based on their status.

Poem

🐰💻🌟
In the realm of code, where logic plays,
A rabbit hopped through the array.
Tweaking the gas with a gentle paw,
Ensuring no byte nor cycle's flaw.
Celebrate the dance of digits and dreams,
In the soft glow of the monitor beams.
🌟💻🐰


Recent Review Details

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between 4f34139 and c2e83c0.
Files selected for processing (1)
  • services/rfq/relayer/service/statushandler.go (1 hunks)
Additional comments not posted (1)
services/rfq/relayer/service/statushandler.go (1)

126-131: The logic to exclude in-flight requests from gas checks is implemented correctly. However, consider adding a comment to clarify why RelayStarted status is included in the isInFlight check, as it's not explicitly mentioned in the PR description or the AI-generated summary.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added go Pull requests that update Go code size/xs labels Apr 13, 2024
Copy link

codecov bot commented Apr 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.02425%. Comparing base (a6ecff3) to head (c2e83c0).
Report is 2 commits behind head on master.

Additional details and impacted files
@@                 Coverage Diff                 @@
##              master       #2496         +/-   ##
===================================================
+ Coverage   47.01926%   47.02425%   +0.00498%     
===================================================
  Files            384         384                 
  Lines          29439       29438          -1     
  Branches          83          83                 
===================================================
+ Hits           13842       13843          +1     
+ Misses         14145       14144          -1     
+ Partials        1452        1451          -1     
Flag Coverage Δ
stiprelayer 3.33333% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: c2e83c0
Status: ✅  Deploy successful!
Preview URL: https://19b5865c.sanguine-fe.pages.dev
Branch Preview URL: https://fix-rfq-double-count-availab.sanguine-fe.pages.dev

View logs

@aureliusbtc aureliusbtc changed the title Fix: gas value check only for non-in-flight requests [goreleaser] Fix: gas value check only for non-in-flight requests Apr 13, 2024
@aureliusbtc aureliusbtc merged commit a84c384 into master Apr 13, 2024
31 checks passed
@aureliusbtc aureliusbtc deleted the fix/rfq-double-count-available-balance branch April 13, 2024 18:20
trajan0x added a commit that referenced this pull request Apr 15, 2024
* Publish

 - @synapsecns/synapse-interface@0.16.6

* Fix: gas value check only for non-in-flight requests (#2496)

* wrap workflow (#2497)

Co-authored-by: Trajan0x <trajan0x@users.noreply.github.com>

* pause op (#2498)

Co-authored-by: Trajan0x <trajan0x@users.noreply.github.com>

---------

Co-authored-by: trajan0x <trajan0x@users.noreply.github.com>
Co-authored-by: χ² <88190723+ChiTimesChi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants