[goreleaser] casing on rfq #2489

aureliusbtc · 2024-04-12T15:40:08Z

Description
A clear and concise description of the features you're adding in this pull request.

Additional context
Add any other context about the problem you're solving.

Metadata

Fixes #[Link to Issue]

Summary by CodeRabbit

New Features
- Updated the underlying blockchain contracts to enhance functionality and security.
Bug Fixes
- Improved the reliability of token symbol matching by implementing case-insensitive comparison, ensuring accurate data retrieval across various token addresses.

coderabbitai · 2024-04-12T15:40:16Z

Walkthrough

The recent update involves refining the functionality of the service components. It includes updating the subproject commit hash for synapse-contracts and improving token address comparison in rfqFetcher for better data handling accuracy.

Changes

File Path	Change Summary
`.../synapse-contracts`	Updated subproject commit hash from `1087590e7139...` to `47fe6e8d69c2...`
`.../fetcher/rfqfetcher.go`	Modified token address comparison to use `strings.EqualFold` for case-insensitive matching
`.../parser/rfqparser.go`	Enhanced token handling logic for ETH and USDC, updated price data application based on token type

🐰🌟
In the code's woven maze, a change was made,
A hash was shifted, in contracts it laid.
Strings now embrace, regardless of case,
A rabbit hops through, leaving a trace.
Joy in each line, as errors decline. 🚀🌌

Recent Review Details

Configuration used: .coderabbit.yaml

Commits

Files that changed from the base of the PR and between f3c9668 and 4fd8820.

Files selected for processing (1)

services/explorer/consumer/parser/rfqparser.go (4 hunks)

Additional Context Used

GitHub Check Runs (1)

Lint (services/explorer) failure (4)

services/explorer/consumer/parser/rfqparser.go: [failure] 114-114:
var curCoinGeckoId should be curCoinGeckoID (golint)

Additional comments not posted (2)

services/explorer/consumer/parser/rfqparser.go (2)

24-24: The addition of the constant ethCoinGeckoID is appropriate and follows Go naming conventions.

118-129: The handling of ETH tokens is correctly implemented. However, assuming any other token as USDC might not be robust. Consider adding a mechanism to handle other tokens more dynamically or at least log a warning when an unrecognized token is encountered.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

cloudflare-workers-and-pages · 2024-04-12T15:46:32Z

Deploying sanguine-fe with Cloudflare Pages

Latest commit:	`4fd8820`
Status:	⚡️ Build in progress...

View logs

codecov · 2024-04-12T15:47:11Z

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 47.02864%. Comparing base (a6fafaa) to head (f3c9668).
Report is 2 commits behind head on master.

❗ Current head f3c9668 differs from pull request most recent head 4fd8820. Consider uploading reports for the commit 4fd8820 to get more accurate results

Files	Patch %	Lines
services/explorer/consumer/fetcher/rfqfetcher.go	0.00000%	2 Missing ⚠️

Additional details and impacted files

@@                 Coverage Diff                 @@
##              master       #2489         +/-   ##
===================================================
- Coverage   47.04202%   47.02864%   -0.01338%     
===================================================
  Files            384         401         +17     
  Lines          29412       30794       +1382     
  Branches          83          83                 
===================================================
+ Hits           13836       14482        +646     
- Misses         14123       14787        +664     
- Partials        1453        1525         +72

Flag	Coverage Δ
cctp-relayer	`43.53414% <ø> (?)`
explorer	`24.03144% <0.00000%> (ø)`
promexporter	`75.91241% <ø> (?)`
rfq	`30.04392% <ø> (ø)`
stiprelayer	`3.33333% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

coderabbitai

Actionable comments posted: 1

coderabbitai · 2024-04-12T19:41:56Z

services/explorer/consumer/parser/rfqparser.go

-	}
-	decimals := tokenData.Decimals()
-	rfqEvent.TokenSymbol = tokenData.TokenID()
+	var curCoinGeckoId string


Consider renaming the variable curCoinGeckoId to curCoinGeckoID to align with Go's naming conventions for acronyms.

- var curCoinGeckoId string + var curCoinGeckoID string

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

var curCoinGeckoId string

var curCoinGeckoID string

[goreleaser] casing on rfq

f3c9668

aureliusbtc requested a review from trajan0x as a code owner April 12, 2024 15:40

github-actions bot added go Pull requests that update Go code size/xs labels Apr 12, 2024

github-actions bot added the needs-go-generate-services/explorer label Apr 12, 2024

adding hot fix for eth and token price discovery

4fd8820

aureliusbtc merged commit 227487b into master Apr 12, 2024
48 of 50 checks passed

aureliusbtc deleted the explorer/rfq-casing branch April 12, 2024 19:39

coderabbitai bot reviewed Apr 12, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[goreleaser] casing on rfq #2489

[goreleaser] casing on rfq #2489

aureliusbtc commented Apr 12, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 12, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

cloudflare-workers-and-pages bot commented Apr 12, 2024 •

edited

Loading

codecov bot commented Apr 12, 2024 •

edited

Loading

coderabbitai bot left a comment

coderabbitai bot Apr 12, 2024

[goreleaser] casing on rfq #2489

[goreleaser] casing on rfq #2489

Conversation

aureliusbtc commented Apr 12, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Apr 12, 2024 • edited Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

cloudflare-workers-and-pages bot commented Apr 12, 2024 • edited Loading

Deploying sanguine-fe with Cloudflare Pages

codecov bot commented Apr 12, 2024 • edited Loading

Codecov Report

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot Apr 12, 2024

Choose a reason for hiding this comment

aureliusbtc commented Apr 12, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 12, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

cloudflare-workers-and-pages bot commented Apr 12, 2024 •

edited

Loading

codecov bot commented Apr 12, 2024 •

edited

Loading