Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE Release 2024-04-11 #2488

Merged
merged 3 commits into from
Apr 11, 2024
Merged

FE Release 2024-04-11 #2488

merged 3 commits into from
Apr 11, 2024

Conversation

bigboydiamonds
Copy link
Collaborator

@bigboydiamonds bigboydiamonds commented Apr 11, 2024

Summary by CodeRabbit

  • New Features

    • Added METIS to the supported chains in the maintenance events interface.
    • Updated maintenance event banners and warnings for clarity and accuracy.
  • Bug Fixes

    • Corrected references to outdated chain names in the user interface.
  • Chores

    • Updated the version number of the @synapsecns/synapse-interface package.
  • Documentation

    • Updated maintenance dates in the user interface documentation.

72fd4705bf37503aa24faef666d2db7314489990: synapse-interface preview link

aureliusbtc and others added 3 commits April 11, 2024 22:32
#2479)

* add dynamic gas limit setting inline of executor, remove old gas limit buffer in config [goreleaser]

* [goreleaser] re-work gas estimation

* [goreleaser] add logs to be reverted

* [goreleaser] revert to old logic but using dynamic gas estimation

* Chore: lint

---------

Co-authored-by: ChiTimesChi <88190723+ChiTimesChi@users.noreply.github.com>
 - @synapsecns/synapse-interface@0.16.4
Copy link
Contributor

coderabbitai bot commented Apr 11, 2024

Walkthrough

This update involves minor adjustments across several components, mainly focusing on the inclusion of the METIS chain in the synapse-interface and the removal of gasBuffers in the sin-executor. The version bump in synapse-interface signifies these updates without altering core functionalities.

Changes

File Path Change Summary
packages/synapse-interface/.../MaintenanceEvent.tsx & package.json Added METIS to chains, updated maintenance dates and messages, and bumped version to 0.16.4.
sin-executor/.../config.go & executor/executor.go Removed GasBuffer and related elements, simplifying gas management in the executor.

Poem

🌟🐰✨
In the land of code, where the bits align,
A rabbit hopped through, with changes so fine.
METIS now welcomed with banners unfurled,
While gasBuffers vanish, from a simpler world.
Hop, skip, a version bump, glee in the air,
CodeRabbit's work, done with utmost care. 🌟🐰✨


Recent Review Details

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between 966f613 and a6fafaa.
Files selected for processing (5)
  • packages/synapse-interface/CHANGELOG.md (1 hunks)
  • packages/synapse-interface/components/Maintenance/Events/template/MaintenanceEvent.tsx (6 hunks)
  • packages/synapse-interface/package.json (1 hunks)
  • sin-executor/config/config.go (2 hunks)
  • sin-executor/executor/executor.go (4 hunks)
Files skipped from review due to trivial changes (1)
  • packages/synapse-interface/package.json
Additional comments not posted (5)
sin-executor/config/config.go (1)

Line range hint 1-1: File provides clear structuring for configuration settings of the Synapse module. Removal of GasBuffer simplifies the configuration.

packages/synapse-interface/components/Maintenance/Events/template/MaintenanceEvent.tsx (3)

3-3: Added METIS to the list of chains. Ensure that this new chain ID is correctly configured in other parts of the system.

Verification successful

The verification process has confirmed that the METIS.id is referenced in the MaintenanceEvent.tsx file within the synapse-interface package. This file contains specific references to METIS.id in the context of showing warnings and maintenance messages for the METIS chain. This indicates that the METIS chain ID is indeed configured and utilized in parts of the system related to maintenance events.

Based on this information, the addition of METIS to the list of chains and its configuration across relevant parts of the system has been successfully verified.

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Verify that METIS chain ID is configured correctly across the system.
rg --type tsx "METIS.id"

Length of output: 52



Script:

#!/bin/bash
# Correcting the script to search for "METIS.id" in TypeScript (.tsx) files
rg "METIS.id" -g '*.tsx'

Length of output: 312


19-23: Updated maintenance start and end dates. Ensure these dates are reflected correctly in all related components and documentation.

Verification successful

The verification process did not find any references to the old maintenance dates (Date.UTC(2024, 3, 10) and Date.UTC(2025, 3, 19)) in the codebase. This suggests that the updated maintenance start and end dates have been correctly reflected across all relevant components and documentation, as no remnants of the old dates were detected.

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Check for references to the old maintenance dates across the project.
rg --type tsx "Date.UTC(2024, 3, 10)" # Old start date
rg --type tsx "Date.UTC(2025, 3, 19)" # Old end date

Length of output: 135



Script:

#!/bin/bash
# Check for references to the old maintenance dates across the project using a corrected file type search.
rg "Date.UTC(2024, 3, 10)" --type ts --type tsx # Old start date
rg "Date.UTC(2025, 3, 19)" --type ts --type tsx # Old end date

Length of output: 155



Script:

#!/bin/bash
# Check for references to the old maintenance dates across the project without specifying file type.
rg "Date.UTC(2024, 3, 10)" # Old start date
rg "Date.UTC(2025, 3, 19)" # Old end date

Length of output: 57


38-38: Updated banner and warning messages to reference Metis. This change enhances clarity and relevance for the users during the maintenance period.

Also applies to: 67-67

sin-executor/executor/executor.go (1)

Line range hint 1-1: File provides core functionalities for transaction execution. Removal of gasBuffers simplifies the transaction handling process.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added go Pull requests that update Go code M-synapse-interface size/xs labels Apr 11, 2024
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.04202%. Comparing base (c500b06) to head (a6fafaa).
Report is 10 commits behind head on fe-release.

Additional details and impacted files
@@                 Coverage Diff                  @@
##           fe-release       #2488         +/-   ##
====================================================
- Coverage    47.36686%   47.04202%   -0.32485%     
====================================================
  Files             429         384         -45     
  Lines           30401       29412        -989     
  Branches          255          83        -172     
====================================================
- Hits            14400       13836        -564     
+ Misses          14528       14123        -405     
+ Partials         1473        1453         -20     
Flag Coverage Δ
packages 90.52734% <ø> (ø)
solidity ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bigboydiamonds bigboydiamonds merged commit e3f8539 into fe-release Apr 11, 2024
16 checks passed
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Comment on lines +10 to +13




Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reduce the number of consecutive blank lines to maintain Markdown best practices.

- 
- 
- 
- 

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code M-synapse-interface size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants