Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redeploy ClientV1 contracts #2482

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Conversation

ChiTimesChi
Copy link
Collaborator

@ChiTimesChi ChiTimesChi commented Apr 11, 2024

Description
A clear and concise description of the features you're adding in this pull request.

Additional context
Add any other context about the problem you're solving.

Metadata

  • Fixes #[Link to Issue]

Summary by CodeRabbit

  • Bug Fixes
    • Updated contract details and improved error handling across blockchain deployments to enhance reliability and user transactions.

Copy link
Contributor

coderabbitai bot commented Apr 11, 2024

Walkthrough

The recent updates involve modifications to the InterchainClientV1.json in both the arb_sepolia and eth_sepolia directories. Key changes include updated contract addresses, receipt hashes, and block numbers. Additionally, a new error type InterchainClientV1__NotEnoughGasSupplied has been introduced across both deployments.

Changes

File Path Changes
.../arb_sepolia/InterchainClientV1.json
.../eth_sepolia/InterchainClientV1.json
Updated addresses, receipt hashes, block numbers, and added error type InterchainClientV1__NotEnoughGasSupplied.

Poem

🐰🌟
In the digital fields where smart contracts play,
Changes abound in the files today.
With updated addresses, hashes anew,
A rabbit hops through, leaving traces in dew.
Beware the gas, for it might just be less,
In the world of code, it's a new quest to address!
🌿📜


Recent Review Details

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between 15de78d and 00e5bed.
Files selected for processing (2)
  • packages/contracts-communication/deployments/arb_sepolia/InterchainClientV1.json (2 hunks)
  • packages/contracts-communication/deployments/eth_sepolia/InterchainClientV1.json (2 hunks)
Additional comments not posted (6)
packages/contracts-communication/deployments/eth_sepolia/InterchainClientV1.json (3)

2-2: Updated contract address to 0x5a81Dfa5885058ED838fa750060C804B49F69991. Ensure this address is correct and corresponds to the intended deployment on the eth_sepolia network.


5-6: Updated transaction receipt details with hash 0x4f95897e9833d15cd2f900065d59fb6d51aca97da096c83d257045be5a7e171a and block number 5675682. Verify that these details accurately reflect the transaction on the blockchain.


808-811: Added new error type InterchainClientV1__NotEnoughGasSupplied. This is a critical update for better error handling in scenarios of insufficient gas supply. Ensure that this new error type is integrated and handled appropriately in the contract's logic.

packages/contracts-communication/deployments/arb_sepolia/InterchainClientV1.json (3)

2-2: Updated contract address to 0xBdC170214726a994D9A837b15C0039bdeE090878. Confirm that this address is correct and corresponds to the intended deployment on the arb_sepolia network.


5-6: Updated transaction receipt details with hash 0x81c0476e7ebb24333ed1a0f9339c26d261b91f1688da9b30afab6c9952892bc5 and block number 32628003. Verify that these details accurately reflect the transaction on the blockchain.


808-811: Added new error type InterchainClientV1__NotEnoughGasSupplied. This is a critical update for better error handling in scenarios of insufficient gas supply. Ensure that this new error type is integrated and handled appropriately in the contract's logic.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 00e5bed
Status: ✅  Deploy successful!
Preview URL: https://af6bcd95.sanguine-fe.pages.dev
Branch Preview URL: https://deploy-ic-client-with-gaslef.sanguine-fe.pages.dev

View logs

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.36686%. Comparing base (15de78d) to head (00e5bed).

Additional details and impacted files
@@                 Coverage Diff                 @@
##              master       #2482         +/-   ##
===================================================
+ Coverage   47.05442%   47.36686%   +0.31244%     
===================================================
  Files            384         429         +45     
  Lines          29417       30401        +984     
  Branches          83         255        +172     
===================================================
+ Hits           13842       14400        +558     
- Misses         14123       14528        +405     
- Partials        1452        1473         +21     
Flag Coverage Δ
packages 90.52734% <ø> (-0.09767%) ⬇️
solidity 56.80894% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChiTimesChi ChiTimesChi merged commit c500b06 into master Apr 11, 2024
51 checks passed
@ChiTimesChi ChiTimesChi deleted the deploy/ic-client-with-gasleft-check branch April 11, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant