Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFQ: add TestHasSufficientGas #2478

Merged
merged 3 commits into from
Apr 9, 2024
Merged

RFQ: add TestHasSufficientGas #2478

merged 3 commits into from
Apr 9, 2024

Conversation

dwasse
Copy link
Collaborator

@dwasse dwasse commented Apr 9, 2024

Summary by CodeRabbit

  • Refactor
    • Improved gas sufficiency checks for transactions, enhancing reliability.
  • Tests
    • Added tests for new gas sufficiency validation logic.

Copy link
Contributor

coderabbitai bot commented Apr 9, 2024

Walkthrough

The recent modifications focus on enhancing the inventoryManagerImpl struct, particularly its HasSufficientGas method, to better handle gas sufficiency checks by separately evaluating the gas thresholds for both origin and destination. Additionally, a new test function ensures the reliability of these changes by simulating various scenarios to test gas sufficiency for relayer funding.

Changes

File Path Change Summary
.../rfq/relayer/inventory/manager.go Updated HasSufficientGas method for separate origin and dest gas threshold checks and refined error messaging.
.../rfq/relayer/inventory/manager_test.go Introduced TestHasSufficientGas() in the InventoryTestSuite for testing relayer funding gas sufficiency across different scenarios.

🐰✨
In the realm of code, where logic beams bright,
A rabbit hopped in, to fix gas just right.
With a tweak and a test, it danced with glee,
For origin and dest, as efficient as can be.
"Hooray!" it exclaimed, with every line neat,
Ensuring the relayer's journey, oh so sweet.
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added go Pull requests that update Go code size/s labels Apr 9, 2024
Copy link

cloudflare-workers-and-pages bot commented Apr 9, 2024

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 86d8edf
Status: ✅  Deploy successful!
Preview URL: https://e2cc20f3.sanguine-fe.pages.dev
Branch Preview URL: https://fix-gas-thresh-test.sanguine-fe.pages.dev

View logs

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.05102%. Comparing base (20862a6) to head (86d8edf).

Additional details and impacted files
@@                 Coverage Diff                 @@
##              master       #2478         +/-   ##
===================================================
+ Coverage   46.88785%   47.05102%   +0.16317%     
===================================================
  Files            384         384                 
  Lines          29417       29417                 
  Branches          83          83                 
===================================================
+ Hits           13793       13841         +48     
+ Misses         14181       14123         -58     
- Partials        1443        1453         +10     
Flag Coverage Δ
rfq 30.04392% <ø> (+1.23998%) ⬆️
stiprelayer 3.33333% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aureliusbtc aureliusbtc merged commit f5c715e into master Apr 9, 2024
31 checks passed
@aureliusbtc aureliusbtc deleted the fix/gas-thresh-test branch April 9, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants