Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[goreleaser] Adding RFQ to the Explorer [goreleaser] #2474

Merged
merged 21 commits into from
Apr 9, 2024

Conversation

Defi-Moses
Copy link
Collaborator

@Defi-Moses Defi-Moses commented Apr 9, 2024

This PR follows the logic here to include the FastBridge contracts in the indexing for the Synapse Explorer. The contracts are already tracked by scribe and pass all locally built tests.

Last things to check before updating helm are:

  • assure that all tokenPrices are fetched properly (we reuse an old function but want to make sure it covers everything)
  • Figure out where db inserts happen outside of tests (and if we need to create new tables etc.

Summary by CodeRabbit

  • New Features
    • Expanded test coverage to handle three chains and new contracts, including fast bridge contracts.
    • Integrated fast bridge parsing logic alongside existing parsers for bridge and CCTP contracts.
    • Introduced support for RFQ events, enabling parsing, querying, and display in the explorer.
  • Enhancements
    • Updated explorer configuration to accommodate new contract types and settings.
    • Improved handling of RFQ data and fast bridge contract events in database and node processing.
  • Bug Fixes
    • Ensured consistent handling of new event types and contracts throughout the application.

@github-actions github-actions bot added go Pull requests that update Go code size/l labels Apr 9, 2024
Copy link
Contributor

coderabbitai bot commented Apr 9, 2024

Walkthrough

The recent update enhances the system by introducing a new contract type, FastBridge, and a new contract, RFQ, for the third chain. This update expands test coverage to handle operations for three chains and integrates parsing logic for fastbridge contracts.

Changes

Files Change Summary
services/explorer/api/resolver_test.go
services/explorer/api/server.go
Reorders imports, adds new contracts and test data for chainID3, and integrates fast bridge parsing logic.
services/explorer/api/suite_test.go Reorganizes imports and incorporates RFQ configurations.
services/explorer/graphql/server/graph/model/models_gen.go
services/explorer/types/utils.go
Updates constants, validation, and types to accommodate FastBridge fields.

🐰✨
In the world of code, where logic intertwines,
A rabbit hopped in, with updates in lines.
RFQs and bridges, in data they dance,
Crafting a web, of enhanced finance.
Let's celebrate, with carrots 🥕 and cheer,
For the changes we've made, progress draws near.
🌟🐾


Recent Review Status

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between 5485c19 and 4d08614.
Files selected for processing (1)
  • services/explorer/api/resolver_test.go (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • services/explorer/api/resolver_test.go

Warning

Following problems were encountered

  • Git: Failed to clone repository. Please contact CodeRabbit support.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

cloudflare-workers-and-pages bot commented Apr 9, 2024

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4d08614
Status: ✅  Deploy successful!
Preview URL: https://77d966a8.sanguine-fe.pages.dev
Branch Preview URL: https://feat-rfq-explorer.sanguine-fe.pages.dev

View logs

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 16.77852% with 248 lines in your changes are missing coverage. Please review.

Project coverage is 47.03373%. Comparing base (a0cf0d4) to head (4d08614).
Report is 3 commits behind head on master.

Files Patch % Lines
services/explorer/consumer/parser/rfqparser.go 0.00000% 193 Missing ⚠️
services/explorer/consumer/fetcher/rfqfetcher.go 0.00000% 20 Missing ⚠️
services/explorer/node/explorer.go 0.00000% 12 Missing ⚠️
services/explorer/consumer/parser/utils.go 0.00000% 10 Missing ⚠️
services/explorer/api/server.go 60.86957% 6 Missing and 3 partials ⚠️
services/explorer/testutil/contracttype.go 0.00000% 2 Missing ⚠️
...es/explorer/testutil/testcontracts/contracttype.go 0.00000% 2 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##              master       #2474         +/-   ##
===================================================
- Coverage   47.19370%   47.03373%   -0.15998%     
===================================================
  Files            399         388         -11     
  Lines          30485       29532        -953     
  Branches          83          83                 
===================================================
- Hits           14387       13890        -497     
+ Misses         14585       14194        -391     
+ Partials        1513        1448         -65     
Flag Coverage Δ
cctp-relayer ?
explorer 24.03144% <16.77852%> (-0.76979%) ⬇️
promexporter 75.91241% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 30

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

services/explorer/api/resolver_test.go Outdated Show resolved Hide resolved
services/explorer/api/server.go Show resolved Hide resolved
services/explorer/api/server.go Show resolved Hide resolved
@aureliusbtc aureliusbtc changed the title Adding RFQ to the Explorer [goreleaser] Adding RFQ to the Explorer [goreleaser] Apr 9, 2024
@aureliusbtc aureliusbtc merged commit b0468e9 into master Apr 9, 2024
48 of 49 checks passed
@aureliusbtc aureliusbtc deleted the feat/rfq-explorer branch April 9, 2024 18:45
@trajan0x trajan0x mentioned this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants