-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[goreleaser] Submitter: adjust Gas Tip Minimum Comparison #2468
Conversation
WalkthroughThe recent update involves a crucial adjustment in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2468 +/- ##
===================================================
- Coverage 47.15101% 47.12097% -0.03004%
===================================================
Files 382 399 +17
Lines 29098 30479 +1381
Branches 83 83
===================================================
+ Hits 13720 14362 +642
- Misses 13936 14602 +666
- Partials 1442 1515 +73
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Status
Configuration used: .coderabbit.yaml
Files selected for processing (1)
- ethergo/submitter/submitter.go (1 hunks)
Additional comments not posted (1)
ethergo/submitter/submitter.go (1)
449-449
: Adjust the comparison logic forGasTipCap
to useminTipCap
.This change aligns with the PR's objective to adjust the comparison logic for
GasTipCap
from comparing againstgasFloor
to comparing againstminTipCap
. It's a targeted improvement aimed at optimizing gas price handling for transactions.
Deploying sanguine-fe with Cloudflare Pages
|
Description
A clear and concise description of the features you're adding in this pull request.
Additional context
Add any other context about the problem you're solving.
Metadata
Summary by CodeRabbit
GasTipCap
to enhance transaction efficiency under specific conditions.