fix(solidity-devops): set only priority fee until foundry bug is fixed #2447
Conversation
WalkthroughThe recent update focuses on a workaround in the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://github.com/avatars/in/347564?s=60&v=4){kind=small}
| /* | ||
| TODO: reenable this once the foundry bug is fixed: https://github.com/foundry-rs/foundry/issues/7486 | ||
| Currently the maxGasPrice is used for both base and priority, rendering the setting of priority fee useless. | ||
|
|
||
| // Use 2*base + priority as the max gas price | ||
| const maxGasPrice = 2 * baseFee + priorityFee | ||
| return options.replace( | ||
| OPTION_AUTO_FILL_GAS_PRICE_1559, | ||
| `--with-gas-price ${maxGasPrice} --priority-gas-price ${priorityFee}` | ||
| ) | ||
| */ | ||
| return options.replace( | ||
| OPTION_AUTO_FILL_GAS_PRICE_1559, | ||
| `--priority-gas-price ${priorityFee}` | ||
| ) |
There was a problem hiding this comment.
Consider adding a more detailed comment explaining the temporary nature of this workaround, including a link to the Foundry issue and a note about the intended reintegration of the original logic.
/*
+ // Temporary workaround for Foundry bug #7486
+ // Issue link: https://github.com/foundry-rs/foundry/issues/7486
+ // This change bypasses the original calculation of maxGasPrice to avoid incorrect gas fee settings.
+ // The original logic should be reintegrated once the Foundry bug is resolved.
TODO: reenable this once the foundry bug is fixed: https://github.com/foundry-rs/foundry/issues/7486
Currently the maxGasPrice is used for both base and priority, rendering the setting of priority fee useless.Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| /* | |
| TODO: reenable this once the foundry bug is fixed: https://github.com/foundry-rs/foundry/issues/7486 | |
| Currently the maxGasPrice is used for both base and priority, rendering the setting of priority fee useless. | |
| // Use 2*base + priority as the max gas price | |
| const maxGasPrice = 2 * baseFee + priorityFee | |
| return options.replace( | |
| OPTION_AUTO_FILL_GAS_PRICE_1559, | |
| `--with-gas-price ${maxGasPrice} --priority-gas-price ${priorityFee}` | |
| ) | |
| */ | |
| return options.replace( | |
| OPTION_AUTO_FILL_GAS_PRICE_1559, | |
| `--priority-gas-price ${priorityFee}` | |
| ) | |
| /* | |
| // Temporary workaround for Foundry bug #7486 | |
| // Issue link: https://github.com/foundry-rs/foundry/issues/7486 | |
| // This change bypasses the original calculation of maxGasPrice to avoid incorrect gas fee settings. | |
| // The original logic should be reintegrated once the Foundry bug is resolved. | |
| TODO: reenable this once the foundry bug is fixed: https://github.com/foundry-rs/foundry/issues/7486 | |
| Currently the maxGasPrice is used for both base and priority, rendering the setting of priority fee useless. | |
| // Use 2*base + priority as the max gas price | |
| const maxGasPrice = 2 * baseFee + priorityFee | |
| return options.replace( | |
| OPTION_AUTO_FILL_GAS_PRICE_1559, | |
| `--with-gas-price ${maxGasPrice} --priority-gas-price ${priorityFee}` | |
| ) | |
| */ | |
| return options.replace( | |
| OPTION_AUTO_FILL_GAS_PRICE_1559, | |
| `--priority-gas-price ${priorityFee}` | |
| ) |
Description
Temp fix to prevent sending txs with
maxGasFee = maxPriority, like this one:Additional context
Summary by CodeRabbit
maxGasPricecalculation in gas price options due to a bug, now using onlypriorityFee.