Add params for client instrumentation #2428
Conversation
|
Warning Rate Limit Exceeded@trajan0x has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 13 minutes and 15 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent update introduces enhancements in metrics and HTTP instrumentation, alongside modifications to the Ethereum client functionality. Key changes include the addition of new block-related metric names, improved HTTP request tracking through JSON parsing, and enhanced contract call tracing capabilities. These adjustments aim to refine data collection and analysis, offering more granular insights into blockchain interactions and performance metrics. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Deploying sanguine-fe with
|
| Latest commit: |
cbf58be
|
| Status: | 🚫 Build failed. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2428 +/- ##
===================================================
+ Coverage 46.93787% 47.10586% +0.16799%
===================================================
Files 383 387 +4
Lines 29228 29387 +159
Branches 83 83
===================================================
+ Hits 13719 13843 +124
- Misses 14048 14080 +32
- Partials 1461 1464 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This reverts commit fdf4b5f.
trajan0x
requested review from
dwasse,
aureliusbtc and
ChiTimesChi
as code owners
![coderabbitai[bot]](https://github.com/avatars/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review Status
Configuration used: .coderabbit.yaml
Files ignored due to path filters (24)
agents/go.modis excluded by!**/*.modagents/go.sumis excluded by!**/*.sumcommittee/go.modis excluded by!**/*.modcommittee/go.sumis excluded by!**/*.sumcontrib/promexporter/go.modis excluded by!**/*.modcontrib/promexporter/go.sumis excluded by!**/*.sumcore/go.modis excluded by!**/*.modcore/go.sumis excluded by!**/*.sumethergo/go.modis excluded by!**/*.modethergo/go.sumis excluded by!**/*.sumservices/cctp-relayer/go.modis excluded by!**/*.modservices/cctp-relayer/go.sumis excluded by!**/*.sumservices/explorer/go.modis excluded by!**/*.modservices/explorer/go.sumis excluded by!**/*.sumservices/omnirpc/go.modis excluded by!**/*.modservices/omnirpc/go.sumis excluded by!**/*.sumservices/rfq/go.modis excluded by!**/*.modservices/rfq/go.sumis excluded by!**/*.sumservices/scribe/go.modis excluded by!**/*.modservices/scribe/go.sumis excluded by!**/*.sumservices/stiprelayer/go.modis excluded by!**/*.modservices/stiprelayer/go.sumis excluded by!**/*.sumsin-executor/go.modis excluded by!**/*.modsin-executor/go.sumis excluded by!**/*.sum
Files selected for processing (3)
- core/metrics/consistentnames.go (1 hunks)
- core/metrics/instrumentation/http.go (4 hunks)
- ethergo/client/client.go (4 hunks)
Additional Context Used
GitHub Check Runs (1)
Lint (core) failure (4)
core/metrics/instrumentation/http.go: [failure] 121-121:
func(*captureTransport).trackIDis unused (unused)
Additional comments not posted (9)
core/metrics/consistentnames.go (1)
18-23: The addition ofBlockHash,FromBlock, andToBlockmetric names is clear and follows the existing naming conventions. These will provide valuable insights into block processing.core/metrics/instrumentation/http.go (3)
7-7: The addition ofgithub.com/valyala/fastjsonis justified for efficient JSON parsing in theRoundTripmethod.
36-37: The addition of theIDSpanNameconstant is appropriate for naming spans associated with request IDs, enhancing traceability.
103-110: The modifications to theRoundTripmethod for extracting and tracking anidfrom the request body are well-implemented and align with the objective of enhancing HTTP instrumentation.ethergo/client/client.go (5)
18-18: The addition of thereflectpackage is justified for use in thenillableToStringfunction to handle nil interface values effectively.
125-126: The modification to thestartSpanmethod to accept an additionaloptsparameter enhances its flexibility and utility for tracing.
144-164: The addition oftoStringsandnillableToStringfunctions is well-implemented, providing useful utilities for converting data types for tracing attributes.
136-136: The modifications to theCallContractandPendingCallContractmethods to include additional attributes in tracing are appropriate and enhance traceability.
297-305: The addition of thequeryToTraceParamsfunction effectively enhances the tracing capabilities of theFilterLogsmethod by convertingethereum.FilterQueryto trace parameters.
trajan0x
changed the title
Description
Future work
Misc:
Staged in #2425
Summary by CodeRabbit
New Features
Enhancements